From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Desnes A. Nunes do Rosario" <desnesn@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: aneesh.kumar@linux.ibm.com, desnesn@linux.ibm.com, shuah@kernel.org
Subject: Re: [PATCH] selftests/powerpc: Fix compiling error on tlbie_test due to newer gcc
Date: Fri, 11 Oct 2019 19:22:05 +1100 (AEDT) [thread overview]
Message-ID: <46qLXY3v7wz9sP7@ozlabs.org> (raw)
In-Reply-To: <20191003211010.9711-1-desnesn@linux.ibm.com>
On Thu, 2019-10-03 at 21:10:10 UTC, "Desnes A. Nunes do Rosario" wrote:
> Newer versions of GCC demand that the size of the string to be copied must
> be explicitly smaller than the size of the destination. Thus, the NULL
> char has to be taken into account on strncpy.
>
> This will avoid the following compiling error:
>
> tlbie_test.c: In function 'main':
> tlbie_test.c:639:4: error: 'strncpy' specified bound 100 equals destination size [-Werror=stringop-truncation]
> strncpy(logdir, optarg, LOGDIR_NAME_SIZE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.ibm.com>
Reapplied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/5b216ea1c40cf06eead15054c70e238c9bd4729e
cheers
prev parent reply other threads:[~2019-10-11 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 21:10 [PATCH] selftests/powerpc: Fix compiling error on tlbie_test due to newer gcc Desnes A. Nunes do Rosario
2019-10-03 23:05 ` Michael Ellerman
2019-10-11 8:22 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46qLXY3v7wz9sP7@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=desnesn@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).