linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: PowerPC dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] cpm: Describe multi-user ram in its own device node.
Date: Tue, 02 Oct 2007 10:49:24 -0500	[thread overview]
Message-ID: <47026884.4040909@freescale.com> (raw)
In-Reply-To: <47025A72.10404@freescale.com>

Timur Tabi wrote:
> The code to process this node is qe_muram_init() in 
> arch/powerpc/sysdev/qe_lib/qe.c.
> 
>     if ((np = of_find_node_by_name(NULL, "data-only")) != NULL) {
>         address = *of_get_address(np, 0, &size, &flags);
>         of_node_put(np);
>         rh_attach_region(&qe_muram_info,
>             (void *)address, (int)size);
>     }
> 
> I think it would be trivial to modify this code to look for a 
> Scott-style muram node.  Heck, it could be modified to look for both, 
> and so we'll maintain compatibility.

I was thinking of just removing the muram code from qe_lib, and having 
it use the code in cpm_common.c.

BTW, searching the entire device tree for a node with the name 
"data-only", regardless of context, seems a bit insane to me.

-Scott

  reply	other threads:[~2007-10-02 17:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 19:06 [PATCH] cpm: Describe multi-user ram in its own device node Scott Wood
2007-09-28 20:06 ` Vitaly Bordug
2007-09-28 20:10   ` Scott Wood
2007-09-28 20:25     ` Vitaly Bordug
2007-09-28 20:30 ` Vitaly Bordug
2007-09-28 23:53   ` Kumar Gala
2007-09-29  6:49     ` Vitaly Bordug
2007-09-29 14:34       ` Kumar Gala
2007-10-01 16:10         ` Scott Wood
2007-10-02 14:43           ` Kumar Gala
2007-10-02 14:49             ` Timur Tabi
2007-10-02 15:49               ` Scott Wood [this message]
2007-10-02 15:51                 ` Timur Tabi
2007-10-02 15:51                   ` Scott Wood
2007-10-02 17:11                   ` Kumar Gala
2007-10-02 14:43 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47026884.4040909@freescale.com \
    --to=scottwood@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).