linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* PowerPC: new EMAC driver typo fix
@ 2007-10-01 14:23 Valentine Barshak
  2007-10-01 23:57 ` Josh Boyer
  0 siblings, 1 reply; 7+ messages in thread
From: Valentine Barshak @ 2007-10-01 14:23 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: david

This looks like typo. Please, apply this patch to fix.

diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
--- linux-2.6.orig/drivers/net/ibm_newemac/core.c	2007-10-01 17:23:35.000000000 +0400
+++ linux-2.6/drivers/net/ibm_newemac/core.c	2007-10-01 17:44:57.000000000 +0400
@@ -1232,9 +1232,9 @@ static inline int emac_xmit_finish(struc
 	 * instead
 	 */
 	if (emac_has_feature(dev, EMAC_FTR_EMAC4))
-		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
-	else
 		out_be32(&p->tmr0, EMAC4_TMR0_XMIT);
+	else
+		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
 
 	if (unlikely(++dev->tx_cnt == NUM_TX_BUFF)) {
 		netif_stop_queue(ndev);

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: PowerPC: new EMAC driver typo fix
  2007-10-01 14:23 PowerPC: new EMAC driver typo fix Valentine Barshak
@ 2007-10-01 23:57 ` Josh Boyer
  2007-10-02  0:10   ` Benjamin Herrenschmidt
  2007-10-02 12:01   ` [PATCH] Fix typo in new EMAC driver Valentine Barshak
  0 siblings, 2 replies; 7+ messages in thread
From: Josh Boyer @ 2007-10-01 23:57 UTC (permalink / raw)
  To: Valentine Barshak; +Cc: linuxppc-dev, david

On Mon, 2007-10-01 at 18:23 +0400, Valentine Barshak wrote:
> This looks like typo. Please, apply this patch to fix.
> 
> diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
> --- linux-2.6.orig/drivers/net/ibm_newemac/core.c	2007-10-01 17:23:35.000000000 +0400
> +++ linux-2.6/drivers/net/ibm_newemac/core.c	2007-10-01 17:44:57.000000000 +0400
> @@ -1232,9 +1232,9 @@ static inline int emac_xmit_finish(struc
>  	 * instead
>  	 */
>  	if (emac_has_feature(dev, EMAC_FTR_EMAC4))
> -		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> -	else
>  		out_be32(&p->tmr0, EMAC4_TMR0_XMIT);
> +	else
> +		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> 
>  	if (unlikely(++dev->tx_cnt == NUM_TX_BUFF)) {
>  		netif_stop_queue(ndev);

No Signed-off-by: line.

The patch looks sane otherwise.  David, Ben, comments?

josh

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: PowerPC: new EMAC driver typo fix
  2007-10-01 23:57 ` Josh Boyer
@ 2007-10-02  0:10   ` Benjamin Herrenschmidt
  2007-10-02 12:01   ` [PATCH] Fix typo in new EMAC driver Valentine Barshak
  1 sibling, 0 replies; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2007-10-02  0:10 UTC (permalink / raw)
  To: Josh Boyer; +Cc: linuxppc-dev, david


On Mon, 2007-10-01 at 18:57 -0500, Josh Boyer wrote:
> On Mon, 2007-10-01 at 18:23 +0400, Valentine Barshak wrote:
> > This looks like typo. Please, apply this patch to fix.
> > 
> > diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
> > --- linux-2.6.orig/drivers/net/ibm_newemac/core.c	2007-10-01 17:23:35.000000000 +0400
> > +++ linux-2.6/drivers/net/ibm_newemac/core.c	2007-10-01 17:44:57.000000000 +0400
> > @@ -1232,9 +1232,9 @@ static inline int emac_xmit_finish(struc
> >  	 * instead
> >  	 */
> >  	if (emac_has_feature(dev, EMAC_FTR_EMAC4))
> > -		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> > -	else
> >  		out_be32(&p->tmr0, EMAC4_TMR0_XMIT);
> > +	else
> > +		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> > 
> >  	if (unlikely(++dev->tx_cnt == NUM_TX_BUFF)) {
> >  		netif_stop_queue(ndev);
> 
> No Signed-off-by: line.
> 
> The patch looks sane otherwise.  David, Ben, comments?

It does definitely look like a genuine typo so Acked by me.

Ben.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] Fix typo in new EMAC driver.
  2007-10-01 23:57 ` Josh Boyer
  2007-10-02  0:10   ` Benjamin Herrenschmidt
@ 2007-10-02 12:01   ` Valentine Barshak
  2007-10-02 17:49     ` Josh Boyer
  2007-10-03 17:51     ` Jeff Garzik
  1 sibling, 2 replies; 7+ messages in thread
From: Valentine Barshak @ 2007-10-02 12:01 UTC (permalink / raw)
  To: linuxppc-dev

Fix an obvious typo in emac_xmit_finish.

Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
 drivers/net/ibm_newemac/core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
--- linux-2.6.orig/drivers/net/ibm_newemac/core.c	2007-10-01 17:23:35.000000000 +0400
+++ linux-2.6/drivers/net/ibm_newemac/core.c	2007-10-01 17:44:57.000000000 +0400
@@ -1232,9 +1232,9 @@ static inline int emac_xmit_finish(struc
 	 * instead
 	 */
 	if (emac_has_feature(dev, EMAC_FTR_EMAC4))
-		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
-	else
 		out_be32(&p->tmr0, EMAC4_TMR0_XMIT);
+	else
+		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
 
 	if (unlikely(++dev->tx_cnt == NUM_TX_BUFF)) {
 		netif_stop_queue(ndev);

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Fix typo in new EMAC driver.
  2007-10-02 12:01   ` [PATCH] Fix typo in new EMAC driver Valentine Barshak
@ 2007-10-02 17:49     ` Josh Boyer
  2007-10-02 17:59       ` Jeff Garzik
  2007-10-03 17:51     ` Jeff Garzik
  1 sibling, 1 reply; 7+ messages in thread
From: Josh Boyer @ 2007-10-02 17:49 UTC (permalink / raw)
  To: Valentine Barshak; +Cc: linuxppc-dev, jeff

On Tue, 2 Oct 2007 16:01:07 +0400
Valentine Barshak <vbarshak@ru.mvista.com> wrote:

> Fix an obvious typo in emac_xmit_finish.
> 
> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>

Looks fine to me.  Jeff, do you want to take this through netdev for
2.6.24?

josh

> ---
>  drivers/net/ibm_newemac/core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
> --- linux-2.6.orig/drivers/net/ibm_newemac/core.c	2007-10-01 17:23:35.000000000 +0400
> +++ linux-2.6/drivers/net/ibm_newemac/core.c	2007-10-01 17:44:57.000000000 +0400
> @@ -1232,9 +1232,9 @@ static inline int emac_xmit_finish(struc
>  	 * instead
>  	 */
>  	if (emac_has_feature(dev, EMAC_FTR_EMAC4))
> -		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> -	else
>  		out_be32(&p->tmr0, EMAC4_TMR0_XMIT);
> +	else
> +		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> 
>  	if (unlikely(++dev->tx_cnt == NUM_TX_BUFF)) {
>  		netif_stop_queue(ndev);
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Fix typo in new EMAC driver.
  2007-10-02 17:49     ` Josh Boyer
@ 2007-10-02 17:59       ` Jeff Garzik
  0 siblings, 0 replies; 7+ messages in thread
From: Jeff Garzik @ 2007-10-02 17:59 UTC (permalink / raw)
  To: Josh Boyer; +Cc: linuxppc-dev

Josh Boyer wrote:
> On Tue, 2 Oct 2007 16:01:07 +0400
> Valentine Barshak <vbarshak@ru.mvista.com> wrote:
> 
>> Fix an obvious typo in emac_xmit_finish.
>>
>> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
> 
> Looks fine to me.  Jeff, do you want to take this through netdev for
> 2.6.24?

sure... can you bounce me the patch without quotes?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Fix typo in new EMAC driver.
  2007-10-02 12:01   ` [PATCH] Fix typo in new EMAC driver Valentine Barshak
  2007-10-02 17:49     ` Josh Boyer
@ 2007-10-03 17:51     ` Jeff Garzik
  1 sibling, 0 replies; 7+ messages in thread
From: Jeff Garzik @ 2007-10-03 17:51 UTC (permalink / raw)
  To: Valentine Barshak (by way of Josh Boyer <jwboyer@linux.vnet.ibm.com>)
  Cc: linuxppc-dev, netdev

Valentine Barshak (by way of Josh Boyer <jwboyer@linux.vnet.ibm.com>) wrote:
> Fix an obvious typo in emac_xmit_finish.
> 
> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
> ---
>  drivers/net/ibm_newemac/core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

applied

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2007-10-03 17:51 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-01 14:23 PowerPC: new EMAC driver typo fix Valentine Barshak
2007-10-01 23:57 ` Josh Boyer
2007-10-02  0:10   ` Benjamin Herrenschmidt
2007-10-02 12:01   ` [PATCH] Fix typo in new EMAC driver Valentine Barshak
2007-10-02 17:49     ` Josh Boyer
2007-10-02 17:59       ` Jeff Garzik
2007-10-03 17:51     ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).