From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 1C303DDFAB for ; Wed, 10 Oct 2007 02:43:26 +1000 (EST) Message-ID: <470BAFA8.1060408@freescale.com> Date: Tue, 09 Oct 2007 11:43:20 -0500 From: Timur Tabi MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH] qe: add function qe_clock_source References: <1191945199488-git-send-email-timur@freescale.com> <470BA5DF.5060206@freescale.com> <2E830F97-ADAE-43CA-9BD3-BEBFEFBE1D5C@kernel.crashing.org> <470BAAA2.30400@freescale.com> <8D4AA8EB-812F-4E58-A13C-CE3BA72037F3@kernel.crashing.org> In-Reply-To: <8D4AA8EB-812F-4E58-A13C-CE3BA72037F3@kernel.crashing.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala wrote: > Ok, I went and looked at how rx-clock & tx-clock are spec'd in > booting-without-of.txt > > Why dont we fix this so we have a property that says "BRG" or "CLK" and > another that has ID = [1.16] for BRG and [1..24] for CLK. Because sometimes you can use both BRGs and CLKs. Some operations can be done only on one or the other, and some can be done on both. The enum itself is fine, I think. I'd rather not split up the two, just report an error if you specify a clock source that's not support for that particular purpose. UART, for instance, can use a CLK signal, but I wrote the driver to only support BRGs because there are plenty of them and it's a lot simpler. But someone, for instance, could wire up his board to want to use external clocks for some UARTs, and so he'd need to modify the driver. -- Timur Tabi Linux Kernel Developer @ Freescale