From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw01.freescale.net (de01egw01.freescale.net [192.88.165.102]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "de01egw01.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 995BEDDFD4 for ; Wed, 10 Oct 2007 04:17:54 +1000 (EST) Message-ID: <470BC5CA.1010105@freescale.com> Date: Tue, 09 Oct 2007 13:17:46 -0500 From: Timur Tabi MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH] qe: add function qe_clock_source References: <1191945199488-git-send-email-timur@freescale.com> <470BA5DF.5060206@freescale.com> <2E830F97-ADAE-43CA-9BD3-BEBFEFBE1D5C@kernel.crashing.org> <470BAAA2.30400@freescale.com> <8D4AA8EB-812F-4E58-A13C-CE3BA72037F3@kernel.crashing.org> <470BAFA8.1060408@freescale.com> <470BB09D.7060304@freescale.com> <470BB0E6.4050801@freescale.com> <470BC484.3060702@freescale.com> <91CB543F-A0F2-42A4-AA5C-6F8FC99F9EC3@kernel.crashing.org> In-Reply-To: <91CB543F-A0F2-42A4-AA5C-6F8FC99F9EC3@kernel.crashing.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala wrote: > But that's a function of linux' use. Remember decouple the device tree > from how linux does things. Ok, I just understand what your point is. I'm proposing that we just put the name of the clock source in the device tree, and have a function which converts that into an internal representation. The clock is called "BRG3". It's not called BRG, #3 or something like that. Same thing with the CLK sources. -- Timur Tabi Linux Kernel Developer @ Freescale