Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

[Jeff Garzik <jeff@garzik.org>]

Josh Boyer wrote:
> On Mon, 15 Oct 2007 14:27:23 -0400
> Jeff Garzik <jeff@garzik.org> wrote:
> 
>> Valentine Barshak wrote:
>>> This patch adds BCM5248 and Marvell 88E1111 PHY support to NEW EMAC driver.
>>> These PHY chips are used on PowerPC 440EPx boards.
>>> The PHY code is based on the previous work by Stefan Roese <sr@denx.de>
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
>>> ---
>>>  drivers/net/ibm_newemac/phy.c |   39 +++++++++++++++++++++++++++++++++++++++
>>>  1 files changed, 39 insertions(+)
>>>
>>> --- linux.orig/drivers/net/ibm_newemac/phy.c	2007-06-15 21:45:18.000000000 +0400
>>> +++ linux/drivers/net/ibm_newemac/phy.c	2007-06-15 20:45:15.000000000 +0400
>>> @@ -306,8 +306,47 @@
>>>  	.ops		= &cis8201_phy_ops
>>>  };
>>>  
>>> +static struct mii_phy_def bcm5248_phy_def = {
>>> +
>>> +	.phy_id		= 0x0143bc00,
>>> +	.phy_id_mask	= 0x0ffffff0,
>>> +	.name		= "BCM5248 10/100 SMII Ethernet",
>>> +	.ops		= &generic_phy_ops
>>> +};
>>> +
>>> +static int m88e1111_init(struct mii_phy *phy)
>>> +{
>>> +	printk("%s: Marvell 88E1111 Ethernet\n", __FUNCTION__);
>>> +	phy_write(phy, 0x14, 0x0ce3);
>>> +	phy_write(phy, 0x18, 0x4101);
>>> +	phy_write(phy, 0x09, 0x0e00);
>>> +	phy_write(phy, 0x04, 0x01e1);
>>> +	phy_write(phy, 0x00, 0x9140);
>>> +	phy_write(phy, 0x00, 0x1140);
>>> +
>>> +	return  0;
>>> +}
>>> +
>>> +static struct mii_phy_ops m88e1111_phy_ops = {
>>> +	.init		= m88e1111_init,
>>> +	.setup_aneg	= genmii_setup_aneg,
>>> +	.setup_forced	= genmii_setup_forced,
>>> +	.poll_link	= genmii_poll_link,
>>> +	.read_link	= genmii_read_link
>>> +};
>>> +
>>> +static struct mii_phy_def m88e1111_phy_def = {
>>> +
>>> +	.phy_id		= 0x01410CC0,
>>> +	.phy_id_mask	= 0x0ffffff0,
>>> +	.name		= "Marvell 88E1111 Ethernet",
>>> +	.ops		= &m88e1111_phy_ops,
>>> +};
>>> +
>>>  static struct mii_phy_def *mii_phy_table[] = {
>>>  	&cis8201_phy_def,
>>> +	&bcm5248_phy_def,
>>> +	&m88e1111_phy_def,
>>>  	&genmii_phy_def,
>> Seems sane to me -- ACK -- but we have multiple people sending me 
>> patches for a single driver.  That's normal for janitorial cleanups 
>> across the whole tree, but discouraged when multiple people are actively 
>> working on the same driver.
>>
>> Please coordinate, and have ONE person send me patches...
> 
> Who else is sending you patches?  Valentine is the only one I've seen
> send patches recently...

It's a zoo :)
Al Viro (3):
       typo in ibm_newemac/rgmii.c
       skb->tail in ibm_newemac should be skb_tail_pointer()
       ibm_newemac annotations (iomem, NULL noise)

David Gibson (1):
       Device tree aware EMAC driver

Michael Ellerman (3):
       Update ibm_newemac to use dcr_host_t.base
       Add dcr_host_t.base in dcr_read()/dcr_write()
       Use dcr_host_t.base in dcr_unmap()

Roland Dreier (2):
       ibm_new_emac: Nuke SET_MODULE_OWNER() use
       ibm_emac: Convert to use napi_struct independent of struct net_device

vbarshak@ru.mvista.com (1):
       Fix typo in new EMAC driver.