From: Scott Wood <scottwood@freescale.com>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [UNTESTED PATCH v2] 8xx: Convert mpc866ads to the new device binding.
Date: Tue, 16 Oct 2007 12:55:20 -0500 [thread overview]
Message-ID: <4714FB08.7090100@freescale.com> (raw)
In-Reply-To: <20071016215308.764d9922@vitb.ru.mvista.com>
Vitaly Bordug wrote:
> Hi Scott,
>
> orig one does not build (not your issue apparently):
>
> CC drivers/net/fs_enet/fs_enet-main.o
> drivers/net/fs_enet/fs_enet-main.c: In function `fs_enet_probe':
> drivers/net/fs_enet/fs_enet-main.c:1252: error: implicit declaration of
> function `SET_MODULE_OWNER'
> drivers/net/fs_enet/fs_enet-main.c:1292: error: structure has no member
> named `poll'
> drivers/net/fs_enet/fs_enet-main.c:1293: error: structure has no member
> named `weight'
> make[3]: *** [drivers/net/fs_enet/fs_enet-main.o] Error 1
> make[2]: *** [drivers/net/fs_enet] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> because net_device does not have 'poll' and 'weight' anymore.
>
> Moreover, with the patch, it does not seem to boot(with upper lines commented out to get it build). I'm investigating the reason right now.
Yeah, I was working on cleaning up the mess when I got this message. :-)
Removing the napi_enable call should make it boot. I'm now trying to
get in to work with napi enabled...
-Scott
prev parent reply other threads:[~2007-10-16 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 22:48 [UNTESTED PATCH v2] 8xx: Convert mpc866ads to the new device binding Scott Wood
2007-10-09 7:53 ` Vitaly Bordug
2007-10-16 17:53 ` Vitaly Bordug
2007-10-16 17:55 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4714FB08.7090100@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).