* PPC405GP Walnut irq patch
@ 2007-10-30 21:06 Steven A. Falco
2007-10-30 21:41 ` Steven A. Falco
0 siblings, 1 reply; 5+ messages in thread
From: Steven A. Falco @ 2007-10-30 21:06 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
Hi - I have found a bug in the ARCH=powerpc Walnut BSP. The order of
the ethernet interrupts in the walnut.dts file doesn't match the
documentation. I discovered this when porting the BSP to a custom board
- the ethernet would not work. The attached patch corrects that.
This is the first patch I am submitting, so please advise me if there is
anything I should do differently.
Signed-off-by: Steve Falco <sfalco at harris.com>
[-- Attachment #2: irq.patch --]
[-- Type: text/x-patch, Size: 578 bytes --]
--- walnut.dts.orig 2007-10-30 15:27:49.000000000 -0400
+++ walnut.dts 2007-10-30 15:29:40.000000000 -0400
@@ -67,7 +67,7 @@
num-tx-chans = <2>;
num-rx-chans = <1>;
interrupt-parent = <&UIC0>;
- interrupts = <a 4 b 4 c 4 d 4 e 4>;
+ interrupts = <b 4 c 4 a 4 d 4 e 4>;
};
POB0: opb {
@@ -117,7 +117,7 @@
device_type = "network";
compatible = "ibm,emac-405gp", "ibm,emac";
interrupt-parent = <&UIC0>;
- interrupts = <9 4 f 4>;
+ interrupts = <f 4 9 4>;
reg = <ef600800 70>;
mal-device = <&MAL>;
mal-tx-channel = <0 1>;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: PPC405GP Walnut irq patch
2007-10-30 21:06 PPC405GP Walnut irq patch Steven A. Falco
@ 2007-10-30 21:41 ` Steven A. Falco
2007-10-31 1:40 ` Josh Boyer
0 siblings, 1 reply; 5+ messages in thread
From: Steven A. Falco @ 2007-10-30 21:41 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
I realized that I should have done this from the root level. So here is
the corrected patch.
Signed-off-by: Steve Falco <sfalco at harris.com>
Steven A. Falco wrote:
> Hi - I have found a bug in the ARCH=powerpc Walnut BSP. The order of
> the ethernet interrupts in the walnut.dts file doesn't match the
> documentation. I discovered this when porting the BSP to a custom
> board - the ethernet would not work. The attached patch corrects that.
>
> This is the first patch I am submitting, so please advise me if there
> is anything I should do differently.
>
> Signed-off-by: Steve Falco <sfalco at harris.com>
>
>
[-- Attachment #2: irq.patch --]
[-- Type: text/x-patch, Size: 660 bytes --]
diff --git a/arch/powerpc/boot/dts/walnut.dts b/arch/powerpc/boot/dts/walnut.dts
index 27bef06..dd65115 100644
--- a/arch/powerpc/boot/dts/walnut.dts
+++ b/arch/powerpc/boot/dts/walnut.dts
@@ -67,7 +67,7 @@
num-tx-chans = <2>;
num-rx-chans = <1>;
interrupt-parent = <&UIC0>;
- interrupts = <a 4 b 4 c 4 d 4 e 4>;
+ interrupts = <b 4 c 4 a 4 d 4 e 4>;
};
POB0: opb {
@@ -117,7 +117,7 @@
device_type = "network";
compatible = "ibm,emac-405gp", "ibm,emac";
interrupt-parent = <&UIC0>;
- interrupts = <9 4 f 4>;
+ interrupts = <f 4 9 4>;
reg = <ef600800 70>;
mal-device = <&MAL>;
mal-tx-channel = <0 1>;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: PPC405GP Walnut irq patch
2007-10-30 21:41 ` Steven A. Falco
@ 2007-10-31 1:40 ` Josh Boyer
2007-10-31 17:52 ` Steven A. Falco
0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2007-10-31 1:40 UTC (permalink / raw)
To: Steven A. Falco; +Cc: linuxppc-dev
On Tue, 30 Oct 2007 17:41:27 -0400
"Steven A. Falco" <sfalco@harris.com> wrote:
> From: "Steven A. Falco" <sfalco@harris.com>
> To: linuxppc-dev@ozlabs.org
> Subject: Re: PPC405GP Walnut irq patch
> Date: Tue, 30 Oct 2007 17:41:27 -0400
> Sender: linuxppc-dev-bounces+jwboyer=gmail.com@ozlabs.org
> User-Agent: Thunderbird 2.0.0.5 (X11/20070719)
>
> I realized that I should have done this from the root level. So here is
> the corrected patch.
>
> Signed-off-by: Steve Falco <sfalco at harris.com>
>
>
> Steven A. Falco wrote:
> > Hi - I have found a bug in the ARCH=powerpc Walnut BSP. The order of
> > the ethernet interrupts in the walnut.dts file doesn't match the
> > documentation. I discovered this when porting the BSP to a custom
> > board - the ethernet would not work. The attached patch corrects that.
> >
> > This is the first patch I am submitting, so please advise me if there
> > is anything I should do differently.
> >
> > Signed-off-by: Steve Falco <sfalco at harris.com>
> >
> >
>
> diff --git a/arch/powerpc/boot/dts/walnut.dts b/arch/powerpc/boot/dts/walnut.dts
> index 27bef06..dd65115 100644
> --- a/arch/powerpc/boot/dts/walnut.dts
> +++ b/arch/powerpc/boot/dts/walnut.dts
> @@ -67,7 +67,7 @@
> num-tx-chans = <2>;
> num-rx-chans = <1>;
> interrupt-parent = <&UIC0>;
> - interrupts = <a 4 b 4 c 4 d 4 e 4>;
> + interrupts = <b 4 c 4 a 4 d 4 e 4>;
> };
I fixed this part already. Seems your tree is slightly old.
>
> POB0: opb {
> @@ -117,7 +117,7 @@
> device_type = "network";
> compatible = "ibm,emac-405gp", "ibm,emac";
> interrupt-parent = <&UIC0>;
> - interrupts = <9 4 f 4>;
> + interrupts = <f 4 9 4>;
Could you redo the patch with just this bit and send it again?
josh
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: PPC405GP Walnut irq patch
2007-10-31 1:40 ` Josh Boyer
@ 2007-10-31 17:52 ` Steven A. Falco
2007-11-01 12:23 ` Josh Boyer
0 siblings, 1 reply; 5+ messages in thread
From: Steven A. Falco @ 2007-10-31 17:52 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
> Could you redo the patch with just this bit and send it again?
>
> josh
>
Ok - this one is based off the Linus tree, and follows your style of one
interrupt per line, with a comment indicating which one it is.
Signed-off-by: Steve Falco <sfalco at harris.com>
[-- Attachment #2: irq.patch --]
[-- Type: text/x-patch, Size: 548 bytes --]
diff --git a/arch/powerpc/boot/dts/walnut.dts b/arch/powerpc/boot/dts/walnut.dts
index fa681f5..754fa39 100644
--- a/arch/powerpc/boot/dts/walnut.dts
+++ b/arch/powerpc/boot/dts/walnut.dts
@@ -122,7 +122,9 @@
device_type = "network";
compatible = "ibm,emac-405gp", "ibm,emac";
interrupt-parent = <&UIC0>;
- interrupts = <9 4 f 4>;
+ interrupts = <
+ f 4 /* Ethernet */
+ 9 4 /* Ethernet Wake Up */>;
local-mac-address = [000000000000]; /* Filled in by zImage */
reg = <ef600800 70>;
mal-device = <&MAL>;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: PPC405GP Walnut irq patch
2007-10-31 17:52 ` Steven A. Falco
@ 2007-11-01 12:23 ` Josh Boyer
0 siblings, 0 replies; 5+ messages in thread
From: Josh Boyer @ 2007-11-01 12:23 UTC (permalink / raw)
To: Steven A. Falco; +Cc: linuxppc-dev
On Wed, 31 Oct 2007 13:52:53 -0400
"Steven A. Falco" <sfalco@harris.com> wrote:
> > Could you redo the patch with just this bit and send it again?
> >
> > josh
> >
>
> Ok - this one is based off the Linus tree, and follows your style of one
> interrupt per line, with a comment indicating which one it is.
Looks good. Thanks!
josh
>
> Signed-off-by: Steve Falco <sfalco at harris.com>
>
>
>
> diff --git a/arch/powerpc/boot/dts/walnut.dts b/arch/powerpc/boot/dts/walnut.dts
> index fa681f5..754fa39 100644
> --- a/arch/powerpc/boot/dts/walnut.dts
> +++ b/arch/powerpc/boot/dts/walnut.dts
> @@ -122,7 +122,9 @@
> device_type = "network";
> compatible = "ibm,emac-405gp", "ibm,emac";
> interrupt-parent = <&UIC0>;
> - interrupts = <9 4 f 4>;
> + interrupts = <
> + f 4 /* Ethernet */
> + 9 4 /* Ethernet Wake Up */>;
> local-mac-address = [000000000000]; /* Filled in by zImage */
> reg = <ef600800 70>;
> mal-device = <&MAL>;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-01 12:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 21:06 PPC405GP Walnut irq patch Steven A. Falco
2007-10-30 21:41 ` Steven A. Falco
2007-10-31 1:40 ` Josh Boyer
2007-10-31 17:52 ` Steven A. Falco
2007-11-01 12:23 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).