From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id 7D754DDE2B for ; Wed, 31 Oct 2007 23:27:19 +1100 (EST) Message-ID: <4728745D.9050603@ru.mvista.com> Date: Wed, 31 Oct 2007 15:26:05 +0300 From: Valentine Barshak MIME-Version: 1.0 To: Olof Johansson Subject: Re: [PATCH 2/4] PowerPC: 440GRx Rainier DTS. References: <20071030164511.GA21973@ru.mvista.com> <20071030165650.GA22107@ru.mvista.com> <20071030230805.GC2784@localhost.localdomain> <20071031015651.GB19318@lixom.net> In-Reply-To: <20071031015651.GB19318@lixom.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Olof Johansson wrote: > On Wed, Oct 31, 2007 at 10:08:05AM +1100, David Gibson wrote: >> On Tue, Oct 30, 2007 at 07:56:50PM +0300, Valentine Barshak wrote: >>> PowerPC 440GRx Rainier DTS. >> [snip] >>> + SDRAM0: sdram { >>> + device_type = "memory-controller"; >> How many times do we need to say it... >> >> Don't make up random device_type values. This does not belong here. > > Maybe there should be something like checkpatch.pl that warns about > these kinds of things so people can check for it without getting flamed > first. :-) > > Lots of people base their dts'es on other ones, so until the kernel has > bene clean a while, this will happen all the time. I'm saying "a while" > because people tend to base them on what's fresh when they do the work, > but it might take a few months between then and when they post, etc. Yep, It's been copy-pasted from sequoia.dts. Sorry for that, I'll rmove both. Thanks, Valentine. > > > -Olof