From: Marian Balakowicz <m8@semihalf.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 05/12] [POWERPC] Export mpc52xx_map_node() routine symbol
Date: Tue, 06 Nov 2007 13:23:56 +0100 [thread overview]
Message-ID: <47305CDC.4050808@semihalf.com> (raw)
In-Reply-To: <20071104150920.d0eac1ef.sfr@canb.auug.org.au>
Hi Stephan,
Stephen Rothwell wrote:
>
> On Sun, 04 Nov 2007 00:52:40 +0100 Marian Balakowicz <m8@semihalf.com> wrote:
>> -static void __iomem *
>> +void __iomem *
>> mpc52xx_map_node(struct device_node *ofn)
>> {
>> const u32 *regaddr_p;
>> @@ -48,6 +48,8 @@ mpc52xx_map_node(struct device_node *ofn)
>> return ioremap((u32)regaddr64, (u32)size64);
>> }
>>
>> +EXPORT_SYMBOL(mpc52xx_map_node);
>> +
>
> We generally don't leave a blank line between a function an its
> EXPORT_SYMBOL().
Will fix that.
> Also, any reason not to use EXPORT_SYMBOL_GPL?
No, no particular reason, I used EXPORT_SYMBOL because it's used for
exporting symbols in this file. But that's good point, I'll switch to
EXPORT_SYMBOL_GPL and I guess it would be nice to convert other
EXPORT_SYMBOL to EXPORT_SYMBOL_GPL as well, but that would be a
separate patch.
Cheers,
m.
next prev parent reply other threads:[~2007-11-06 12:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 23:52 [PATCH v2 00/12] [POWERPC] Add TQM5200/CM5200/Motion-PRO board support Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 01/12] [POWERPC] Add 'model: ...' line to common show_cpuinfo() Marian Balakowicz
2007-11-04 22:17 ` David Gibson
2007-11-05 1:40 ` Olof Johansson
2007-11-03 23:52 ` [PATCH v2 02/12] [POWERPC] Add 'fsl, lpb' bus type for MPC5200 LocalPlus Bus Marian Balakowicz
2007-11-04 22:18 ` David Gibson
2007-11-03 23:52 ` [PATCH v2 03/12] [POWERPC] Add common mpc52xx_setup_pci() routine Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 04/12] [POWERPC] Add generic support for simple MPC5200 based boards Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 05/12] [POWERPC] Export mpc52xx_map_node() routine symbol Marian Balakowicz
2007-11-04 4:09 ` Stephen Rothwell
2007-11-06 12:23 ` Marian Balakowicz [this message]
2007-11-03 23:52 ` [PATCH v2 06/12] [POWERPC] TQM5200 DTS Marian Balakowicz
2007-11-05 0:47 ` David Gibson
2007-11-06 19:50 ` Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 07/12] [POWERPC] TQM5200 defconfig Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 08/12] [POWERPC] CM5200 DTS Marian Balakowicz
2007-11-05 0:50 ` David Gibson
2007-11-06 19:18 ` Marian Balakowicz
2007-11-03 23:53 ` [PATCH v2 09/12] [POWERPC] CM5200 defconfig Marian Balakowicz
2007-11-03 23:53 ` [PATCH v2 10/12] [POWERPC] Motion-PRO: Add LED support Marian Balakowicz
2007-11-04 4:27 ` Stephen Rothwell
2007-11-06 11:58 ` Marian Balakowicz
2007-11-03 23:53 ` [PATCH v2 11/12] [POWERPC] Promess Motion-PRO DTS Marian Balakowicz
2007-11-05 0:56 ` David Gibson
2007-11-06 20:02 ` Marian Balakowicz
2007-11-03 23:53 ` [PATCH v2 12/12] [POWERPC] Promess Motion-PRO defconfig Marian Balakowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47305CDC.4050808@semihalf.com \
--to=m8@semihalf.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).