From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1420FCA9EC6 for ; Wed, 30 Oct 2019 13:02:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA5382087E for ; Wed, 30 Oct 2019 13:02:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA5382087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4737s953CkzF3cc for ; Thu, 31 Oct 2019 00:02:21 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4736qq6RXrzF4Br for ; Wed, 30 Oct 2019 23:16:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 4736qq4GvHz9sPw; Wed, 30 Oct 2019 23:16:07 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 7d6475051fb3d9339c5c760ed9883bc0a9048b21 In-Reply-To: <20191022115814.22456-1-npiggin@gmail.com> To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [PATCH] powerpc/powernv: Fix CPU idle to be called with IRQs disabled Message-Id: <4736qq4GvHz9sPw@ozlabs.org> Date: Wed, 30 Oct 2019 23:16:07 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras , Nicholas Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 2019-10-22 at 11:58:14 UTC, Nicholas Piggin wrote: > Commit e78a7614f3876 ("idle: Prevent late-arriving interrupts from > disrupting offline") changes arch_cpu_idle_dead to be called with > interrupts disabled, which triggers the WARN in pnv_smp_cpu_kill_self. > > Fix this by fixing up irq_happened after hard disabling, rather than > requiring there are no pending interrupts, similarly to what was done > done until commit 2525db04d1cc5 ("powerpc/powernv: Simplify lazy IRQ > handling in CPU offline"). > > Fixes: e78a7614f3876 ("idle: Prevent late-arriving interrupts from disrupting offline") > Reported-by: Paul Mackerras > Signed-off-by: Nicholas Piggin Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/7d6475051fb3d9339c5c760ed9883bc0a9048b21 cheers