* [PATCH] powerpc: Add support for PORTA sor and PORTB odr registers
@ 2007-11-11 17:08 Jochen Friedrich
2007-11-12 17:42 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Jochen Friedrich @ 2007-11-11 17:08 UTC (permalink / raw)
To: linuxppc-embedded@ozlabs.org; +Cc: paulus, linux-kernel
PORTA has an so register and PORTB had an odr register, as well.
However, the PORTB odr register is only 16bit.
Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
arch/powerpc/sysdev/commproc.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/commproc.c b/arch/powerpc/sysdev/commproc.c
index f6a6378..a9f5fcf 100644
--- a/arch/powerpc/sysdev/commproc.c
+++ b/arch/powerpc/sysdev/commproc.c
@@ -438,6 +438,13 @@ static void cpm1_set_pin32(int port, int pin, int flags)
else
clrbits32(&iop->par, pin);
+ if (port == CPM_PORTB) {
+ if (flags & CPM_PIN_OPENDRAIN)
+ setbits16(&mpc8xx_immr->im_cpm.cp_pbodr, pin);
+ else
+ clrbits16(&mpc8xx_immr->im_cpm.cp_pbodr, pin);
+ }
+
if (port == CPM_PORTE) {
if (flags & CPM_PIN_SECONDARY)
setbits32(&iop->sor, pin);
@@ -471,7 +478,7 @@ static void cpm1_set_pin16(int port, int pin, int flags)
else
clrbits16(&iop->par, pin);
- if (port == CPM_PORTC) {
+ if ((port == CPM_PORTA) || (port == CPM_PORTC)) {
if (flags & CPM_PIN_SECONDARY)
setbits16(&iop->sor, pin);
else
--
1.5.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Add support for PORTA sor and PORTB odr registers
2007-11-11 17:08 [PATCH] powerpc: Add support for PORTA sor and PORTB odr registers Jochen Friedrich
@ 2007-11-12 17:42 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2007-11-12 17:42 UTC (permalink / raw)
To: Jochen Friedrich; +Cc: paulus, linux-kernel, linuxppc-embedded@ozlabs.org
Jochen Friedrich wrote:
> PORTA has an so register and PORTB had an odr register, as well.
> However, the PORTB odr register is only 16bit.
Which 8xx chip has a so register on port A? I checked the 860, 866,
885, and 823 manuals and didn't see one.
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-12 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-11 17:08 [PATCH] powerpc: Add support for PORTA sor and PORTB odr registers Jochen Friedrich
2007-11-12 17:42 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).