From: Marian Balakowicz <m8@semihalf.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v5 04/13] [POWERPC] Add generic support for simple MPC5200 based boards
Date: Thu, 15 Nov 2007 12:06:46 +0100 [thread overview]
Message-ID: <473C2846.2010701@semihalf.com> (raw)
In-Reply-To: <20071115102149.898061fb.sfr@canb.auug.org.au>
Hi Stephen,
Stephen Rothwell wrote:
>
> On Wed, 14 Nov 2007 11:21:37 +0100 Marian Balakowicz <m8@semihalf.com> wrote:
>> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
>> +#include <asm/time.h>
>> +#include <asm/machdep.h>
>> +#include <asm/mpc52xx.h>
>
> You still need asm/prom.h because you use of_get_flat_dt_root() and
> of_flat_dt_is_compatible().
>
>> +/* list of the supported boards */
>> +static const char *board[] __initdata = {
>
> Unfortunately you can't use "const" and "__initdata", so just remove the
> "const". (const changes the attributes on the section that __initdata is
> stored in.)
Arghh, too much of a hurry it seems, thanks for catching it.
Cheers,
m.
prev parent reply other threads:[~2007-11-15 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 10:21 [PATCH v5 04/13] [POWERPC] Add generic support for simple MPC5200 based boards Marian Balakowicz
2007-11-14 23:21 ` Stephen Rothwell
2007-11-15 11:06 ` Marian Balakowicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473C2846.2010701@semihalf.com \
--to=m8@semihalf.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).