linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Clemens Koller <clemens.koller@anagramm.de>
To: benh@kernel.crashing.org
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: Latest paulus.git PCI broken on mpc8540?
Date: Fri, 16 Nov 2007 22:14:51 +0100	[thread overview]
Message-ID: <473E084B.4080703@anagramm.de> (raw)
In-Reply-To: <1195247357.28865.178.camel@pasglop>

Hi, Ben!

Benjamin Herrenschmidt schrieb:
> On Fri, 2007-11-16 at 13:18 -0600, Kumar Gala wrote:
>>
>> Well, for one the generic pci code will complain if its not able to  
>> allocate the resource which is the true failure.
>>
>> I'm thinking maybe we just make these pr_debug() instead of standard  
>> printk?
> 
> I was thinking about changing the message to "cannot allocate initial
> resource, will reallocate" or something like that. That is, make it
> clear it's non fatal.

I don't know much of the code, so, propably a stupid question:
Can we avoid to do the initial resource allocation, when it's known to fail?

It seems to me like things are done twice here:
1. try
2. reallocate
3. retry

Regards,

-- 
Clemens Koller
_______________________________
R&D Imaging Devices
Anagramm GmbH
Rupert-Mayer-Str. 45/1
81379 Muenchen
Germany

http://www.anagramm-technology.com
Phone: +49-89-741518-50
Fax: +49-89-741518-19

  reply	other threads:[~2007-11-16 21:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15 17:20 Latest paulus.git PCI broken on mpc8540? Clemens Koller
2007-11-16  4:37 ` Kumar Gala
2007-11-16  5:35   ` Benjamin Herrenschmidt
2007-11-16 19:18     ` Kumar Gala
2007-11-16 21:09       ` Benjamin Herrenschmidt
2007-11-16 21:14         ` Clemens Koller [this message]
2007-11-16 21:20           ` Benjamin Herrenschmidt
2007-11-16 21:45         ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473E084B.4080703@anagramm.de \
    --to=clemens.koller@anagramm.de \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).