From: Timur Tabi <timur@freescale.com>
To: Clemens Koller <clemens.koller@anagramm.de>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: Oops: of_platform_serial_probe
Date: Mon, 19 Nov 2007 10:34:59 -0600 [thread overview]
Message-ID: <4741BB33.6060206@freescale.com> (raw)
In-Reply-To: <4741B934.90400@anagramm.de>
Clemens Koller wrote:
> Timur Tabi schrieb:
> > Clemens Koller wrote:
> >
> >> I guess I didn't configure the OF serial right in the .dts but it still
> >> shouldn't crash. My .config is attached.
> >
> > Try disabling CONFIG_SERIAL_OF_PLATFORM. I don't think it means what
> > you think it means.
>
> Thanks, disabling CONFIG_SERIAL_OF_PLATFORM helps. but it still
> shouldn't crash...
That's a bug in the OF serial driver. It's expecting fields in the serial
node that don't exist. You are right, however. The driver should at least
check for NULL pointers. If I had any hardware that used that driver, I would
fix it myself.
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-11-19 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 13:46 Oops: of_platform_serial_probe Clemens Koller
2007-11-19 15:04 ` Timur Tabi
2007-11-19 16:26 ` Clemens Koller
2007-11-19 16:34 ` Timur Tabi [this message]
2007-11-19 16:56 ` Arnd Bergmann
2007-11-20 10:52 ` Clemens Koller
2007-11-20 12:05 ` Arnd Bergmann
2007-11-20 12:49 ` Clemens Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4741BB33.6060206@freescale.com \
--to=timur@freescale.com \
--cc=clemens.koller@anagramm.de \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).