From: Scott Wood <scottwood@freescale.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Emulate isel (Integer Select) instruction
Date: Wed, 21 Nov 2007 15:41:00 -0600 [thread overview]
Message-ID: <4744A5EC.1090201@freescale.com> (raw)
In-Reply-To: <18244.42181.426804.662877@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Geert Uytterhoeven writes:
>
>> +#define WARN_EMULATE(type) \
>> + do { \
>> + static unsigned int count; \
>> + if (count++ < 10) \
>> + pr_warning("%s used emulated %s instruction\n", \
>> + current->comm, type); \
>
> Thinking about this a bit more, if an instruction gets emulated 10
> times then I don't care, since it's probably only cost me 10
> microseconds or so. If it gets emulated a million times then I might
> want to look at it. So in fact this approach doesn't give me the
> information I need to know whether there is a real problem or not.
Maybe print the first time, then when it's happened 10 times, then 100,
then 1000, etc.
-Scott
next prev parent reply other threads:[~2007-11-21 21:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 3:36 [PATCH] [POWERPC] Emulate isel (Integer Select) instruction Kumar Gala
2007-11-20 17:54 ` Scott Wood
2007-11-20 21:01 ` Kumar Gala
2007-11-21 9:12 ` Benjamin Herrenschmidt
2007-11-21 14:19 ` Kumar Gala
2007-11-21 13:09 ` Geert Uytterhoeven
2007-11-21 14:22 ` Kumar Gala
2007-11-21 14:33 ` Geert Uytterhoeven
2007-11-21 15:34 ` Kumar Gala
2007-11-21 16:50 ` Geert Uytterhoeven
2007-11-21 19:22 ` Kumar Gala
2007-11-21 21:31 ` Paul Mackerras
2007-11-21 21:36 ` Paul Mackerras
2007-11-21 21:41 ` Scott Wood [this message]
2007-11-21 21:48 ` Kim Phillips
2007-11-21 21:38 ` Paul Mackerras
2007-11-27 14:56 ` Geert Uytterhoeven
2007-11-27 15:23 ` Olof Johansson
2007-11-28 10:49 ` Geert Uytterhoeven
2007-11-29 15:13 ` Geert Uytterhoeven
2007-12-14 8:12 ` Olof Johansson
2007-12-14 8:08 ` Kumar Gala
2007-12-14 8:17 ` Olof Johansson
2007-12-14 8:16 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4744A5EC.1090201@freescale.com \
--to=scottwood@freescale.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).