From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 25256DDF0F for ; Wed, 5 Dec 2007 07:07:53 +1100 (EST) Message-ID: <4755B395.6070104@garzik.org> Date: Tue, 04 Dec 2007 15:07:49 -0500 From: Jeff Garzik MIME-Version: 1.0 To: Vitaly Bordug Subject: Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality References: <20071126142906.19642.45540.stgit@localhost.localdomain> In-Reply-To: <20071126142906.19642.45540.stgit@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Vitaly Bordug wrote: > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all emulated PHYs placed on the platform fixed MDIO bus. > There is also no more need to pre-allocate PHYs via .config option, > this is all now handled dynamically. > > p.s. Don't even try to understand patch content! Better: apply patch > and look into resulting drivers/net/phy/fixed.c. > > Signed-off-by: Anton Vorontsov > Signed-off-by: Vitaly Bordug ACK, I presume this will go via the ppc tree?