From: Scott Wood <scottwood@freescale.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support
Date: Wed, 12 Dec 2007 16:48:24 -0600 [thread overview]
Message-ID: <47606538.2090605@freescale.com> (raw)
In-Reply-To: <20071212154306.dee76c80.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
>> + ep8248e_bcsr = of_iomap(ep8248e_bcsr_node, 0);
>
> of_node_put(ep8248e_bcsr_node;
No, because we hold on to the node for later use in ep8248e_mdio_probe().
BTW, is there any actual node removal done that justifies dealing with
refcounts everywhere?
-Scot
next prev parent reply other threads:[~2007-12-12 22:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 21:22 [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support Scott Wood
2007-12-12 4:43 ` Stephen Rothwell
2007-12-12 22:48 ` Scott Wood [this message]
2007-12-13 0:55 ` Stephen Rothwell
2007-12-14 5:19 ` Kumar Gala
2007-12-14 15:53 ` Scott Wood
2007-12-14 16:28 ` Kumar Gala
2007-12-14 18:23 ` Scott Wood
2008-01-02 19:15 ` Jon Loeliger
2007-12-14 22:10 ` David Gibson
2007-12-16 6:30 ` David Gibson
2007-12-16 15:48 ` Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2008-01-11 20:07 Scott Wood
2008-01-14 5:48 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47606538.2090605@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).