From: Scott Wood <scottwood@freescale.com>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC][RFC] MPC8360E-RDK: Device tree and board file
Date: Mon, 17 Dec 2007 12:48:17 -0600 [thread overview]
Message-ID: <4766C471.6050703@freescale.com> (raw)
In-Reply-To: <20071217212654.2cf39355@kernel.crashing.org>
Vitaly Bordug wrote:
> On Mon, 17 Dec 2007 11:03:04 -0600 Scott Wood wrote:
>>> These phy nodes have basically no information in them. PHY nodes
>>> are optional -
>> If they are truly optional, then several Linux drivers (including
>> ucc_geth, which this board uses) are broken, as they'll error out
>> if there's no phy-handle (gianfar is even worse -- it looks like
>> the fsl_soc code will crash in that case). But what do you propose
>> they do in the absence of a phy-handle? Hope that probing only
>> finds one phy?
>
> up-to-date fixed phy patch solves it in gianfar and fs_enet case. it
> is implied, that either there *are* phy nodes (and the code will look
> up their reg and phandle) or there should be fixed-link property in
> NIC node, that describes to what link stuff is really connected.
There's a difference between the phy *node* being optional and phy
*usage* being optional. :-)
-Scott
next prev parent reply other threads:[~2007-12-17 18:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 20:29 [PATCH] [POWERPC][RFC] MPC8360E-RDK: Device tree and board file Anton Vorontsov
2007-12-11 0:30 ` Stephen Rothwell
2007-12-11 17:19 ` Anton Vorontsov
2007-12-11 18:42 ` Kumar Gala
2007-12-15 16:23 ` Anton Vorontsov
2007-12-17 5:14 ` David Gibson
2007-12-17 17:03 ` Scott Wood
2007-12-17 17:10 ` Kim Phillips
2007-12-17 17:20 ` Scott Wood
2007-12-17 17:42 ` Kim Phillips
2007-12-17 18:26 ` Vitaly Bordug
2007-12-17 18:48 ` Scott Wood [this message]
2007-12-17 20:55 ` Vitaly Bordug
2007-12-18 3:51 ` David Gibson
2007-12-18 16:16 ` Scott Wood
2007-12-18 16:51 ` Anton Vorontsov
2007-12-18 22:39 ` David Gibson
2007-12-19 13:05 ` Anton Vorontsov
2007-12-19 16:15 ` Scott Wood
2007-12-19 16:36 ` Anton Vorontsov
2007-12-19 20:59 ` Anton Vorontsov
2007-12-18 15:53 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4766C471.6050703@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).