From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw02.freescale.net (de01egw02.freescale.net [192.88.165.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "de01egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 196ACDDEC1 for ; Tue, 18 Dec 2007 05:49:14 +1100 (EST) Message-ID: <4766C471.6050703@freescale.com> Date: Mon, 17 Dec 2007 12:48:17 -0600 From: Scott Wood MIME-Version: 1.0 To: Vitaly Bordug Subject: Re: [PATCH] [POWERPC][RFC] MPC8360E-RDK: Device tree and board file References: <20071210202934.GA32046@localhost.localdomain> <10D5CABD-442B-44DF-83D7-7FED5CD150E3@kernel.crashing.org> <20071215162331.GA24999@localhost.localdomain> <20071217051403.GB3477@localhost.localdomain> <20071217170303.GA4303@loki.buserror.net> <20071217212654.2cf39355@kernel.crashing.org> In-Reply-To: <20071217212654.2cf39355@kernel.crashing.org> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Stephen Rothwell , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Vitaly Bordug wrote: > On Mon, 17 Dec 2007 11:03:04 -0600 Scott Wood wrote: >>> These phy nodes have basically no information in them. PHY nodes >>> are optional - >> If they are truly optional, then several Linux drivers (including >> ucc_geth, which this board uses) are broken, as they'll error out >> if there's no phy-handle (gianfar is even worse -- it looks like >> the fsl_soc code will crash in that case). But what do you propose >> they do in the absence of a phy-handle? Hope that probing only >> finds one phy? > > up-to-date fixed phy patch solves it in gianfar and fs_enet case. it > is implied, that either there *are* phy nodes (and the code will look > up their reg and phandle) or there should be fixed-link property in > NIC node, that describes to what link stuff is really connected. There's a difference between the phy *node* being optional and phy *usage* being optional. :-) -Scott