From: Timur Tabi <timur@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART
Date: Thu, 03 Jan 2008 12:26:27 -0600 [thread overview]
Message-ID: <477D28D3.3000102@freescale.com> (raw)
In-Reply-To: <20080102181226.GA4486@loki.buserror.net>
Scott Wood wrote:
>>>> +static struct of_platform_driver ucc_uart_of_driver = {
>>>> + .owner = THIS_MODULE,
>>>> + .name = "ucc_uart",
>>> Maybe better fsl,ucc_uart?
>
> fsl,qe-uart is defined by Documentation/powerpc/booting-without-of.txt.
Wait, I'm confused. What does the of_platform_driver.name string have to do
with the compatible field in the device tree? Like I said earlier, I'm just
following the example of the other QE device drivers. If you want me to break
that example, I'm going to need an explanation why the other drivers do it wrong.
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2008-01-03 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 16:44 [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART Timur Tabi
2007-12-26 16:58 ` Anton Vorontsov
2007-12-29 22:10 ` Timur Tabi
2008-01-02 18:12 ` Scott Wood
2008-01-03 18:26 ` Timur Tabi [this message]
2008-01-03 18:26 ` Scott Wood
2008-01-03 23:41 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477D28D3.3000102@freescale.com \
--to=timur@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).