From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <scottwood@freescale.com>
Received: from az33egw02.freescale.net (az33egw02.freescale.net
	[192.88.158.103])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "az33egw02.freescale.net",
	Issuer "Thawte Premium Server CA" (verified OK))
	by ozlabs.org (Postfix) with ESMTP id 525A8DDF45
	for <linuxppc-dev@ozlabs.org>; Fri,  4 Jan 2008 05:26:52 +1100 (EST)
Message-ID: <477D28EC.6070407@freescale.com>
Date: Thu, 03 Jan 2008 12:26:52 -0600
From: Scott Wood <scottwood@freescale.com>
MIME-Version: 1.0
To: Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART
References: <11970458703666-git-send-email-timur@freescale.com>
	<20071226165816.GB11449@localhost.localdomain>
	<4776C5EE.70004@freescale.com>
	<20080102181226.GA4486@loki.buserror.net>
	<477D28D3.3000102@freescale.com>
In-Reply-To: <477D28D3.3000102@freescale.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

Timur Tabi wrote:
> Scott Wood wrote:
> 
>>>>> +static struct of_platform_driver ucc_uart_of_driver = {
>>>>> +    .owner      = THIS_MODULE,
>>>>> +    .name       = "ucc_uart",
>>>> Maybe better fsl,ucc_uart?
>>
>> fsl,qe-uart is defined by Documentation/powerpc/booting-without-of.txt.
> 
> Wait, I'm confused.  What does the of_platform_driver.name string have 
> to do with the compatible field in the device tree?

Bah.  Details.

/me resolves to read the context next time.

-Scott