From: Segher Boessenkool <segher@kernel.crashing.org>
To: will_schmidt@vnet.ibm.com
Cc: Greg Kroah-Hartman <greg@kroah.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Olof Johannsson <olof@lixom.net>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 4/7] MPIC MSI allocator
Date: Thu, 11 Jan 2007 18:27:12 +0100 [thread overview]
Message-ID: <477bb0db0bf2506a38d91d48a81b55c2@kernel.crashing.org> (raw)
In-Reply-To: <1168535981.18021.50.camel@localhost>
>>> + /* Reserve source numbers we know are reserved in the HW */
>>> + for (i = 0; i < 8; i++) __mpic_msi_reserve_hwirq(mpic, i);
>>> + for (i = 42; i < 46; i++) __mpic_msi_reserve_hwirq(mpic, i);
>>> + for (i = 100; i < 105; i++) __mpic_msi_reserve_hwirq(mpic, i);
>>
>> Coding style. The ranges you reserve are a bit too wide,
>> but that is certainly safe.
>
> Can you clarify that comment a bit for me? Why are they too wide,
> and
> if they are too wide, how are they still safe?
A few vectors that can be used freely are marked as
not being so. That is fine, there are plenty left.
Segher
next prev parent reply other threads:[~2007-01-11 17:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 11:25 [PATCH 0/7] Powerpc MSI Implementation Michael Ellerman
2007-01-11 11:25 ` [PATCH 1/7] Rip out the existing powerpc msi stubs Michael Ellerman
2007-01-11 21:31 ` Christoph Hellwig
2007-01-11 11:25 ` [PATCH 2/7] Powerpc MSI implementation Michael Ellerman
2007-01-11 19:44 ` Greg KH
2007-01-11 21:20 ` Benjamin Herrenschmidt
2007-01-11 21:54 ` Benjamin Herrenschmidt
2007-01-12 23:13 ` Greg KH
2007-01-13 5:57 ` Benjamin Herrenschmidt
2007-01-13 19:27 ` Greg KH
2007-01-13 20:40 ` Benjamin Herrenschmidt
2007-01-12 23:11 ` Greg KH
2007-01-11 21:36 ` Christoph Hellwig
2007-01-12 7:27 ` Benjamin Herrenschmidt
2007-01-11 11:25 ` [PATCH 3/7] Enable MSI on Powerpc Michael Ellerman
2007-01-11 21:37 ` Christoph Hellwig
2007-01-12 7:24 ` Benjamin Herrenschmidt
2007-01-11 11:25 ` [PATCH 4/7] MPIC MSI allocator Michael Ellerman
2007-01-11 15:14 ` Segher Boessenkool
2007-01-11 17:19 ` Will Schmidt
2007-01-11 17:27 ` Segher Boessenkool [this message]
2007-01-12 0:27 ` Olof Johansson
2007-01-12 0:33 ` Michael Ellerman
2007-01-11 11:25 ` [PATCH 5/7] MPIC MSI backend Michael Ellerman
2007-01-11 11:25 ` [PATCH 6/7] Enable MSI mappings for MPIC Michael Ellerman
2007-01-11 15:22 ` Segher Boessenkool
2007-01-11 11:25 ` [PATCH 7/7] Activate MSI for the MPIC backend on U3 Michael Ellerman
2007-01-11 15:23 ` [PATCH 0/7] Powerpc MSI Implementation Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477bb0db0bf2506a38d91d48a81b55c2@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).