83xx, ELDK 2.6.23, IP-Config: No network devices

83xx, ELDK 2.6.23, IP-Config: No network devices

[Russell McGuire]

All,
	
Attempting to get MPC8360 board booted into Linux using a NFS root fs.

I can see the kernel boots up, and registers both the MDIO driver and the
ucc_geth: driver, and with additional debug they encounter no errors.

However, for some reason the probe function never gets called for the MDIO
or the UCC driver. So as a result <assuming> the IP layer never gets a
network device. I am using a National DP83865 PHY device connected directly
to the 83xx QE. I don't see any direct definition for this PHY device, but
it doesn't even look like it queries the ID.

So two questions:

1) Is there some basic kernel feature I am missing? I have enabled the GIGE
UEC GETH driver in the kernel.  Perhaps a PHY LIB? Isn't generic MII
supported by default?

2) Is there something in the startup board files, that I need to add to
register my PHY like an of_put_node()? Again I have pretty much copied the
MPC8360E MDS board and it is starting, and defining the par_io port already,
except that my PHY ID <on the iC2 bus, is using dev ID 0x01>. However, I
don't see the probe function being called, so I don't think this is a
concern yet.

Anyway, how do I get the UEC_driver to see my phy device so I can get the
NFS to boot?

-Russ

Re: 83xx, ELDK 2.6.23, IP-Config: No network devices

[Vitaly Bordug]

On Sun, 30 Dec 2007 16:51:44 -0800
Russell McGuire wrote:

> 1) Is there some basic kernel feature I am missing? I have enabled
> the GIGE UEC GETH driver in the kernel.  Perhaps a PHY LIB? Isn't
> generic MII supported by default?
> 
yes you will need phylib

> 2) Is there something in the startup board files, that I need to add
> to register my PHY like an of_put_node()? Again I have pretty much
> copied the MPC8360E MDS board and it is starting, and defining the
> par_io port already, except that my PHY ID <on the iC2 bus, is using
> dev ID 0x01>. However, I don't see the probe function being called,
> so I don't think this is a concern yet.
I think you will need to write a driver for your specific PHY access to get it covered by phy abstraction layer.
Generic mii thing is useful when it has access to phy regs somehow (live examples are some BCM phys that do not have specs
available but the thing works using generic mii and standard phy regs).

-- 
Sincerely, Vitaly

83xx, ucc_geth, kernel 2.6.23, IP-Config: No network devices

[Russell McGuire]

Ok, I am still stuck on this. 
Why isn't probe being called on any of the Freescale network device drivers?

I can see the Generic MII PHY Driver being registered.
The UCC_GETH and UCC_GETH_MDIO both being registered. 

An for fun, I even modified the Marvell PHY driver devices ID's to correctly
identify a National part that I am using, and I see this registering.

I would appear all the appropriate entries are in the .dts file
for each the different parts (mdio, ucc_geth, ucc_geth_mdio, phy0).

And yet still no probe functions get called for any of those drivers?

I need this to NFS boot, into the ELDK 4.1 file system.

Does anyone have an example of the 2.6.23 kernel working DTS files for a
Freescale 8360 that they are using NFS Booting for? Has anyone proofed this
out, or is everyone else using this as a module or driver that doesn't kick
until after the root file system is loaded?  

Alternatively is there something specific perhaps U-boot is populating in
the OF structure that is preventing my Ethernet phy from being recognized in
the linux kernel? Why are none of the probe functions being called?

-Russ 
> -----Original Message-----
> From: Vitaly Bordug [mailto:vitb@kernel.crashing.org]
> Sent: Monday, December 31, 2007 12:15 AM
> To: rmcguire@videopresence.com
> Cc: linuxppc-embedded@ozlabs.org
> Subject: Re: 83xx, ELDK 2.6.23, IP-Config: No network devices
> 
> On Sun, 30 Dec 2007 16:51:44 -0800
> Russell McGuire wrote:
> 
> > 1) Is there some basic kernel feature I am missing? I have enabled
> > the GIGE UEC GETH driver in the kernel.  Perhaps a PHY LIB? Isn't
> > generic MII supported by default?
> >
> yes you will need phylib
> 
> > 2) Is there something in the startup board files, that I need to add
> > to register my PHY like an of_put_node()? Again I have pretty much
> > copied the MPC8360E MDS board and it is starting, and defining the
> > par_io port already, except that my PHY ID <on the iC2 bus, is using
> > dev ID 0x01>. However, I don't see the probe function being called,
> > so I don't think this is a concern yet.
> I think you will need to write a driver for your specific PHY access to
> get it covered by phy abstraction layer.
> Generic mii thing is useful when it has access to phy regs somehow (live
> examples are some BCM phys that do not have specs
> available but the thing works using generic mii and standard phy regs).

Re: 83xx, ucc_geth, kernel 2.6.23, IP-Config: No network devices

[Jochen Friedrich]

Hi Russell,

> I would appear all the appropriate entries are in the .dts file
> for each the different parts (mdio, ucc_geth, ucc_geth_mdio, phy0).
> 
> And yet still no probe functions get called for any of those drivers?

Do you export the subtree using of_platform_bus_probe()?

Thanks,
Jochen

RE: 83xx, ucc_geth, kernel 2.6.23, IP-Config: No network devices

[Russell McGuire]

Joch,

Thanks, apparently I had a conditional that was not matching up around that
call. So now that I 'am' calling the of_platform_bus_probe(). I can see all
the probe functions getting called.  Thank you very much.

Next question, I can see that 'quick' mods I have made to the Marvell driver
are indeed matching up with the device ID that the Freescale MII device is
pulling back from my 'National' part. <I'll make a real phy driver once I
get this working>. I.e. I can see the phy_probe get called when this Id is
registered.  You can see the extra debug messages above the National DP83865
device registration, and the probe returns 0 for success I assume. <err =
0>.

I am still getting the "IP-Config: No network devices" error before the NFS
boot tries to take place.

BootLog:

RWM DEBUG, uec_mdio_init:278
RWM DEBUG, uec_mdio_probe:145
UCC Ethernet Controller MII Bus: probed
UCC Ethernet Controller MII Bus: Registered
ucc_geth: QE UCC Gigabit Ethernet Controller
Marvell 88E1101: Registered new driver
Marvell 88E1112: Registered new driver
Marvell 88E1111: Registered new driver
RWM DEBUG: phy_probe:635
RWM DEBUG: phy_probe:663 err = 0
National DP83865: Registered new driver
Marvell 88E1145: Registered new driver
HDLC support module revision 1.21
usbmon: debugfs is not available
mice: PS/2 mouse device common for all mice
i2c /dev entries driver
WDT driver for MPC83xx initialized. mode:reset timeout=65535 (16 seconds)
usbcore: registered new interface driver usbhid
drivers/hid/usbhid/hid-core.c: v2.6:USB HID core driver
TCP cubic registered
NET: Registered protocol family 1
NET: Registered protocol family 17
lec.c: Dec 18 2007 15:30:33 initialized
mpc.c: Dec 18 2007 15:30:31 initialized
IP-Config: No network devices available.
.... NFS boot fails

-Russ
> -----Original Message-----
> From: Jochen Friedrich [mailto:jochen@scram.de]
> Sent: Monday, January 07, 2008 3:18 AM
> To: rmcguire@videopresence.com
> Cc: linuxppc-embedded@ozlabs.org
> Subject: Re: 83xx, ucc_geth, kernel 2.6.23, IP-Config: No network devices
> 
> Hi Russell,
> 
> > I would appear all the appropriate entries are in the .dts file
> > for each the different parts (mdio, ucc_geth, ucc_geth_mdio, phy0).
> >
> > And yet still no probe functions get called for any of those drivers?
> 
> Do you export the subtree using of_platform_bus_probe()?
> 
> Thanks,
> Jochen

Re: 83xx, ucc_geth, kernel 2.6.23, IP-Config: No network devices

[Jochen Friedrich]

Hi Russell,

> Next question, I can see that 'quick' mods I have made to the Marvell driver
> are indeed matching up with the device ID that the Freescale MII device is
> pulling back from my 'National' part. <I'll make a real phy driver once I
> get this working>. I.e. I can see the phy_probe get called when this Id is
> registered.  You can see the extra debug messages above the National DP83865
> device registration, and the probe returns 0 for success I assume. <err =
> 0>.
> 
> I am still getting the "IP-Config: No network devices" error before the NFS
> boot tries to take place.

I would add some more debugging printk output to check where the device
initialisation fails. Or if the phy runs without any initialisation, you
could use the fixed-phy patches from Vitali Bordug and hardcode the speed and
duplex settings in the device tree until you real phy driver is finished.

thanks,
Jochen