From: John Rigby <jrigby@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 7/7] Add MPC512x PSC serial driver
Date: Tue, 08 Jan 2008 10:47:57 -0700 [thread overview]
Message-ID: <4783B74D.1040501@freescale.com> (raw)
In-Reply-To: <fa686aa40801080932g71fb6215wc3d6df107bec7238@mail.gmail.com>
Thanks for the quick feedback Grant.
Grant Likely wrote:
> Exactly *how* different is the 5121 PSC from the 5200 PSC? If it is
> really different, then it makes sense to clone.
The fifo handling has completely changed that is the main difference.
> In fact; I'd
> duplicate the mpc52xx_psc.h file also to avoid any crossover.
>
I agree.
> However, if the differences are manegable, I'd rather see a single
> driver that can drive either type of PSC. In fact, can you post a
> diff between this driver and the original PSC driver?
>
I simple diff will mostly show the removal of arch/ppc support so
won't be much help. How about I do take a pass at a new version
that supports 52xx and 512x but only for arch/powerpc?
next prev parent reply other threads:[~2008-01-08 20:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:01 [PATCH 0/7] mpc5121 support John Rigby
2008-01-08 16:01 ` [PATCH 1/7] mpc5121: Add IPIC config option John Rigby
2008-01-08 16:01 ` [PATCH 2/7] Add mpc512x ipic support John Rigby
2008-01-08 16:01 ` [PATCH 3/7] Basic Freescale MPC512x support John Rigby
2008-01-08 16:01 ` [PATCH 4/7] Device tree for MPC5121 ADS John Rigby
2008-01-08 16:01 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC John Rigby
2008-01-08 16:01 ` [PATCH 6/7] Add mpc512x_find_ips_freq John Rigby
2008-01-08 16:01 ` [PATCH 7/7] Add MPC512x PSC serial driver John Rigby
2008-01-08 17:32 ` Grant Likely
2008-01-08 17:47 ` John Rigby [this message]
2008-01-08 20:16 ` Grant Likely
2008-01-09 3:16 ` Stephen Rothwell
2008-01-09 6:06 ` Stephen Rothwell
2008-01-08 17:27 ` [PATCH 6/7] Add mpc512x_find_ips_freq Grant Likely
2008-01-08 18:15 ` Arnd Bergmann
2008-01-08 17:26 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC Grant Likely
2008-01-08 17:25 ` [PATCH 4/7] Device tree for MPC5121 ADS Grant Likely
2008-01-08 19:22 ` Scott Wood
2008-01-10 2:18 ` David Gibson
2008-01-08 17:19 ` [PATCH 3/7] Basic Freescale MPC512x support Grant Likely
2008-01-08 17:55 ` Scott Wood
2008-01-08 17:56 ` Grant Likely
2008-01-08 19:25 ` Scott Wood
2008-01-08 20:37 ` Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support] John Rigby
2008-01-08 21:40 ` Grant Likely
2008-01-08 21:46 ` Scott Wood
2008-01-08 17:40 ` [PATCH 3/7] Basic Freescale MPC512x support Olof Johansson
2008-01-08 17:44 ` Jon Loeliger
2008-01-08 18:01 ` John Rigby
2008-01-08 18:13 ` Arnd Bergmann
2008-01-08 18:16 ` John Rigby
2008-01-08 18:07 ` Arnd Bergmann
2008-01-08 18:25 ` John Rigby
2008-01-09 2:36 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4783B74D.1040501@freescale.com \
--to=jrigby@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).