[PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Kumar Gala]

There were several issues if a memreserve range existed and happened
to be in highmem:

* The bootmem allocator is only aware of lowmem so calling
  reserve_bootmem with a highmem address would cause a BUG_ON
* All highmem pages were provided to the buddy allocator

Added a lmb_is_reserved() api that we now use to determine if a highem
page should continue to be PageReserved or provided to the buddy
allocator.

Also, we incorrectly reported the amount of pages reserved since all
highmem pages are initally marked reserved and we clear the
PageReserved flag as we "free" up the highmem pages.

---

As normal, posted here for review, will be pushed via my for-2.6.25 branch

 arch/powerpc/mm/lmb.c     |   13 +++++++++++++
 arch/powerpc/mm/mem.c     |   14 ++++++++++----
 include/asm-powerpc/lmb.h |    1 +
 3 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/mm/lmb.c b/arch/powerpc/mm/lmb.c
index 8f4d2dc..4ce23bc 100644
--- a/arch/powerpc/mm/lmb.c
+++ b/arch/powerpc/mm/lmb.c
@@ -342,3 +342,16 @@ void __init lmb_enforce_memory_limit(unsigned long memory_limit)
 		}
 	}
 }
+
+int __init lmb_is_reserved(unsigned long addr)
+{
+	int i;
+
+	for (i = 0; i < lmb.reserved.cnt; i++) {
+		unsigned long upper = lmb.reserved.region[i].base +
+				      lmb.reserved.region[i].size - 1;
+		if ((addr >= lmb.reserved.region[i].base) && (addr <= upper))
+			return 1;
+	}
+	return 0;
+}
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 5402fb6..a004032 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -218,9 +218,13 @@ void __init do_init_bootmem(void)
 #endif

 	/* reserve the sections we're already using */
-	for (i = 0; i < lmb.reserved.cnt; i++)
-		reserve_bootmem(lmb.reserved.region[i].base,
-				lmb_size_bytes(&lmb.reserved, i));
+	for (i = 0; i < lmb.reserved.cnt; i++) {
+		unsigned long addr = lmb.reserved.region[i].base +
+				     lmb_size_bytes(&lmb.reserved, i) - 1;
+		if (addr < total_lowmem)
+			reserve_bootmem(lmb.reserved.region[i].base,
+					lmb_size_bytes(&lmb.reserved, i));
+	}

 	/* XXX need to clip this if using highmem? */
 	sparse_memory_present_with_active_regions(0);
@@ -334,11 +338,13 @@ void __init mem_init(void)
 		highmem_mapnr = total_lowmem >> PAGE_SHIFT;
 		for (pfn = highmem_mapnr; pfn < max_mapnr; ++pfn) {
 			struct page *page = pfn_to_page(pfn);
-
+			if (lmb_is_reserved(pfn << PAGE_SHIFT))
+				continue;
 			ClearPageReserved(page);
 			init_page_count(page);
 			__free_page(page);
 			totalhigh_pages++;
+			reservedpages--;
 		}
 		totalram_pages += totalhigh_pages;
 		printk(KERN_DEBUG "High memory: %luk\n",
diff --git a/include/asm-powerpc/lmb.h b/include/asm-powerpc/lmb.h
index b5f9f4c..5d1dc48 100644
--- a/include/asm-powerpc/lmb.h
+++ b/include/asm-powerpc/lmb.h
@@ -51,6 +51,7 @@ extern unsigned long __init __lmb_alloc_base(unsigned long size,
 extern unsigned long __init lmb_phys_mem_size(void);
 extern unsigned long __init lmb_end_of_DRAM(void);
 extern void __init lmb_enforce_memory_limit(unsigned long memory_limit);
+extern int __init lmb_is_reserved(unsigned long addr);

 extern void lmb_dump_all(void);

-- 
1.5.3.7

Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Scott Wood]

On Wed, Jan 09, 2008 at 11:28:30AM -0600, Kumar Gala wrote:
>  	/* reserve the sections we're already using */
> -	for (i = 0; i < lmb.reserved.cnt; i++)
> -		reserve_bootmem(lmb.reserved.region[i].base,
> -				lmb_size_bytes(&lmb.reserved, i));
> +	for (i = 0; i < lmb.reserved.cnt; i++) {
> +		unsigned long addr = lmb.reserved.region[i].base +
> +				     lmb_size_bytes(&lmb.reserved, i) - 1;
> +		if (addr < total_lowmem)
> +			reserve_bootmem(lmb.reserved.region[i].base,
> +					lmb_size_bytes(&lmb.reserved, i));
> +	}

It looks like if the reserved area straddles the highmem boundary, it'll
only reserve the highmem portion.

-Scott

Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Kumar Gala]

On Jan 9, 2008, at 12:53 PM, Scott Wood wrote:

> On Wed, Jan 09, 2008 at 11:28:30AM -0600, Kumar Gala wrote:
>> 	/* reserve the sections we're already using */
>> -	for (i = 0; i < lmb.reserved.cnt; i++)
>> -		reserve_bootmem(lmb.reserved.region[i].base,
>> -				lmb_size_bytes(&lmb.reserved, i));
>> +	for (i = 0; i < lmb.reserved.cnt; i++) {
>> +		unsigned long addr = lmb.reserved.region[i].base +
>> +				     lmb_size_bytes(&lmb.reserved, i) - 1;
>> +		if (addr < total_lowmem)
>> +			reserve_bootmem(lmb.reserved.region[i].base,
>> +					lmb_size_bytes(&lmb.reserved, i));
>> +	}
>
> It looks like if the reserved area straddles the highmem boundary,  
> it'll
> only reserve the highmem portion.

Yeah, I thought about that.  I'm wondering if we should warn about  
this.. its seems like a bad thing to do.

- k

Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Scott Wood]

Kumar Gala wrote:
> On Jan 9, 2008, at 12:53 PM, Scott Wood wrote:
>> It looks like if the reserved area straddles the highmem boundary, it'll
>> only reserve the highmem portion.
> 
> Yeah, I thought about that.  I'm wondering if we should warn about 
> this.. its seems like a bad thing to do.

How is the firmware supposed to know where Linux sets its lowmem limit? 
  I think this is something that needs to be handled.

-Scott

Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Kumar Gala]

On Jan 9, 2008, at 1:30 PM, Scott Wood wrote:

> Kumar Gala wrote:
>> On Jan 9, 2008, at 12:53 PM, Scott Wood wrote:
>>> It looks like if the reserved area straddles the highmem boundary,  
>>> it'll
>>> only reserve the highmem portion.
>> Yeah, I thought about that.  I'm wondering if we should warn about  
>> this.. its seems like a bad thing to do.
>
> How is the firmware supposed to know where Linux sets its lowmem  
> limit?  I think this is something that needs to be handled.

Yeah I agree with that as well.

I'm thinking I'll add something like:

                 if (addr < total_lowmem)
                         reserve_bootmem(lmb.reserved.region[i].base,
                                         lmb_size_bytes(&lmb.reserved,  
i));
+               else if (lmb.reserved.region[i].base > total_lowmem) {
+                       unsigned long adjusted_size;
+//                     adjusted_size = xxx;

need to figure out the math here.

+                       reserve_bootmem(lmb.reserved.region[i].base,
+                                       adjusted_size);
+               }

that should solve the problem.

- k

Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Scott Wood]

Kumar Gala wrote:
> I'm thinking I'll add something like:
> 
>                 if (addr < total_lowmem)
>                         reserve_bootmem(lmb.reserved.region[i].base,
>                                         lmb_size_bytes(&lmb.reserved, i));
> +               else if (lmb.reserved.region[i].base > total_lowmem) {

less than, surely?

> +                       unsigned long adjusted_size;
> +//                     adjusted_size = xxx;
> 
> need to figure out the math here.

Wouldn't it just be total_lowmem - lmb.reserved.region[i].base?

-Scott

Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Kumar Gala]

On Jan 9, 2008, at 1:52 PM, Scott Wood wrote:

> Kumar Gala wrote:
>> I'm thinking I'll add something like:
>>                if (addr < total_lowmem)
>>                        reserve_bootmem(lmb.reserved.region[i].base,
>>                                         
>> lmb_size_bytes(&lmb.reserved, i));
>> +               else if (lmb.reserved.region[i].base >  
>> total_lowmem) {
>
> less than, surely?

damn, why didn't I see your email before a spent 20 minutes debugging  
this ;)

>> +                       unsigned long adjusted_size;
>> +//                     adjusted_size = xxx;
>> need to figure out the math here.
>
> Wouldn't it just be total_lowmem - lmb.reserved.region[i].base?

yep, but that required my brain to have enough time to think about this.

- k

Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem

[Scott Wood]

Kumar Gala wrote:
> 
> On Jan 9, 2008, at 1:52 PM, Scott Wood wrote:
> 
>> Kumar Gala wrote:
>>> I'm thinking I'll add something like:
>>>                if (addr < total_lowmem)
>>>                        reserve_bootmem(lmb.reserved.region[i].base,
>>>                                        lmb_size_bytes(&lmb.reserved, 
>>> i));
>>> +               else if (lmb.reserved.region[i].base > total_lowmem) {
>>
>> less than, surely?
> 
> damn, why didn't I see your email before a spent 20 minutes debugging 
> this ;)

Because, as happens all too often lately, Freescale's mail servers 
needed to chew on it for an hour and a half before sending it on. :-P

-Scott