From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 45DE0DDF2C for ; Thu, 10 Jan 2008 08:13:43 +1100 (EST) Message-ID: <478525E7.3060106@freescale.com> Date: Wed, 09 Jan 2008 13:52:07 -0600 From: Scott Wood MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands in highmem References: <20080109185349.GC4337@loki.buserror.net> <3B831CF0-E978-42E7-BA26-7598BC27A5F6@kernel.crashing.org> <478520E4.1050204@freescale.com> <9536E0AC-E4D2-4E86-8DC6-F40A322FC817@kernel.crashing.org> In-Reply-To: <9536E0AC-E4D2-4E86-8DC6-F40A322FC817@kernel.crashing.org> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala wrote: > I'm thinking I'll add something like: > > if (addr < total_lowmem) > reserve_bootmem(lmb.reserved.region[i].base, > lmb_size_bytes(&lmb.reserved, i)); > + else if (lmb.reserved.region[i].base > total_lowmem) { less than, surely? > + unsigned long adjusted_size; > +// adjusted_size = xxx; > > need to figure out the math here. Wouldn't it just be total_lowmem - lmb.reserved.region[i].base? -Scott