From: Sean MacLennan <smaclennan@pikatech.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Warp Watchdog
Date: Mon, 21 Jan 2008 12:50:34 -0500 [thread overview]
Message-ID: <4794DB6A.1010204@pikatech.com> (raw)
In-Reply-To: <20080121080157.0b66c7fc@zod.rchland.ibm.com>
Josh Boyer wrote:
> I'm not thrilled with it being in the platform file itself. It should
> really go into drivers/watchdog. It's OK that the watchdog is tied to
> Warp, that really isn't an issue. Just make it depend on Warp in the
> Kconfig file. And you can select it in your board config so that it's
> built in-kernel and not as a module.
>
> The code itself looks pretty clean.
>
Thanks for the feedback. I think I was trying to convince myself that
the platform was a good place but honestly felt it should be in the
drivers/watchdog. So I moved it there.
Cheers,
Sean
prev parent reply other threads:[~2008-01-21 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 20:23 Warp Watchdog Sean MacLennan
2008-01-21 14:01 ` Josh Boyer
2008-01-21 17:50 ` Sean MacLennan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4794DB6A.1010204@pikatech.com \
--to=smaclennan@pikatech.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).