* [PATCH] adder875: Fix flash bus-width and remove duplicate __initdata.
@ 2008-01-22 18:31 Scott Wood
2008-01-22 18:33 ` Kumar Gala
2008-01-22 20:05 ` Kumar Gala
0 siblings, 2 replies; 4+ messages in thread
From: Scott Wood @ 2008-01-22 18:31 UTC (permalink / raw)
To: galak; +Cc: linuxppc-dev
Signed-off-by: Scott Wood <scottwood@freescale.com>
---
arch/powerpc/boot/dts/adder875-redboot.dts | 2 +-
arch/powerpc/boot/dts/adder875-uboot.dts | 2 +-
arch/powerpc/platforms/8xx/adder875.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/adder875-redboot.dts b/arch/powerpc/boot/dts/adder875-redboot.dts
index 8f7a79f..930bfb3 100644
--- a/arch/powerpc/boot/dts/adder875-redboot.dts
+++ b/arch/powerpc/boot/dts/adder875-redboot.dts
@@ -62,7 +62,7 @@
flash@0,0 {
compatible = "cfi-flash";
reg = <0 0 0x800000>;
- bank-width = <4>;
+ bank-width = <2>;
device-width = <2>;
};
};
diff --git a/arch/powerpc/boot/dts/adder875-uboot.dts b/arch/powerpc/boot/dts/adder875-uboot.dts
index 60d4ad5..0197242 100644
--- a/arch/powerpc/boot/dts/adder875-uboot.dts
+++ b/arch/powerpc/boot/dts/adder875-uboot.dts
@@ -61,7 +61,7 @@
flash@0,0 {
compatible = "cfi-flash";
reg = <0 0 0x800000>;
- bank-width = <4>;
+ bank-width = <2>;
device-width = <2>;
};
};
diff --git a/arch/powerpc/platforms/8xx/adder875.c b/arch/powerpc/platforms/8xx/adder875.c
index af040fd..c6bc078 100644
--- a/arch/powerpc/platforms/8xx/adder875.c
+++ b/arch/powerpc/platforms/8xx/adder875.c
@@ -92,7 +92,7 @@ static int __init adder875_probe(void)
return of_flat_dt_is_compatible(root, "analogue-and-micro,adder875");
}
-static __initdata struct of_device_id __initdata of_bus_ids[] = {
+static __initdata struct of_device_id of_bus_ids[] = {
{ .compatible = "simple-bus", },
{},
};
--
1.5.3.8
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] adder875: Fix flash bus-width and remove duplicate __initdata.
2008-01-22 18:31 [PATCH] adder875: Fix flash bus-width and remove duplicate __initdata Scott Wood
@ 2008-01-22 18:33 ` Kumar Gala
2008-01-22 18:45 ` Scott Wood
2008-01-22 20:05 ` Kumar Gala
1 sibling, 1 reply; 4+ messages in thread
From: Kumar Gala @ 2008-01-22 18:33 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
On Jan 22, 2008, at 12:31 PM, Scott Wood wrote:
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> arch/powerpc/boot/dts/adder875-redboot.dts | 2 +-
> arch/powerpc/boot/dts/adder875-uboot.dts | 2 +-
> arch/powerpc/platforms/8xx/adder875.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/adder875-redboot.dts b/arch/
> powerpc/boot/dts/adder875-redboot.dts
> index 8f7a79f..930bfb3 100644
> --- a/arch/powerpc/boot/dts/adder875-redboot.dts
> +++ b/arch/powerpc/boot/dts/adder875-redboot.dts
> @@ -62,7 +62,7 @@
> flash@0,0 {
> compatible = "cfi-flash";
> reg = <0 0 0x800000>;
> - bank-width = <4>;
> + bank-width = <2>;
> device-width = <2>;
> };
> };
I'm assuming the bank-width was just wrong before?
- k
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] adder875: Fix flash bus-width and remove duplicate __initdata.
2008-01-22 18:33 ` Kumar Gala
@ 2008-01-22 18:45 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2008-01-22 18:45 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
Kumar Gala wrote:
> On Jan 22, 2008, at 12:31 PM, Scott Wood wrote:
>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> ---
>> arch/powerpc/boot/dts/adder875-redboot.dts | 2 +-
>> arch/powerpc/boot/dts/adder875-uboot.dts | 2 +-
>> arch/powerpc/platforms/8xx/adder875.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/adder875-redboot.dts b/arch/
>> powerpc/boot/dts/adder875-redboot.dts
>> index 8f7a79f..930bfb3 100644
>> --- a/arch/powerpc/boot/dts/adder875-redboot.dts
>> +++ b/arch/powerpc/boot/dts/adder875-redboot.dts
>> @@ -62,7 +62,7 @@
>> flash@0,0 {
>> compatible = "cfi-flash";
>> reg = <0 0 0x800000>;
>> - bank-width = <4>;
>> + bank-width = <2>;
>> device-width = <2>;
>> };
>> };
>
> I'm assuming the bank-width was just wrong before?
Yes, I got a bug report (off-list) about it today. I thought I had
tested it a while back; maybe the dts got reverted to an older version
somewhere along the way.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] adder875: Fix flash bus-width and remove duplicate __initdata.
2008-01-22 18:31 [PATCH] adder875: Fix flash bus-width and remove duplicate __initdata Scott Wood
2008-01-22 18:33 ` Kumar Gala
@ 2008-01-22 20:05 ` Kumar Gala
1 sibling, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2008-01-22 20:05 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
On Tue, 22 Jan 2008, Scott Wood wrote:
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> arch/powerpc/boot/dts/adder875-redboot.dts | 2 +-
> arch/powerpc/boot/dts/adder875-uboot.dts | 2 +-
> arch/powerpc/platforms/8xx/adder875.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
applied.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-01-22 20:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-22 18:31 [PATCH] adder875: Fix flash bus-width and remove duplicate __initdata Scott Wood
2008-01-22 18:33 ` Kumar Gala
2008-01-22 18:45 ` Scott Wood
2008-01-22 20:05 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).