From: Jon Loeliger <jdl@freescale.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, Jon Loeliger <jdl@jdl.com>
Subject: Re: [PATCH 2/3 v3] Add initial iomega StorCenter board port.
Date: Wed, 23 Jan 2008 08:05:14 -0600 [thread overview]
Message-ID: <4797499A.3020506@freescale.com> (raw)
In-Reply-To: <20080123105111.125f075d.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Jon,
>
> On Tue, 22 Jan 2008 16:37:59 -0600 Jon Loeliger <jdl@jdl.com> wrote:
>> +++ b/arch/powerpc/platforms/embedded6xx/storcenter.c
>
>> +extern void _nmask_and_or_msr(unsigned long nmask, unsigned long or_val);
>
> This clearly needs to be decalred in some header file. (I know you did
> not introduce it.) In arch/ppc, it was declared in asm/system.h (but I
> don't know if that is appropriate for arch/powerpc). Maybe you could do
> a preceeding patch that does this and fixes the other user.
I hear my Janitorial Karmic Duty calling.
>> +static void __init storcenter_init_IRQ(void)
>> + prop = of_get_property(dnp, "reg", &size);
>> + paddr = (phys_addr_t)of_translate_address(dnp, prop);
>
> What happens of "prop" is NULL?
Someone should fix that case too. :-)
Kumar,
I'll respin this trio for you.
jdl
prev parent reply other threads:[~2008-01-23 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 22:37 [PATCH 2/3 v3] Add initial iomega StorCenter board port Jon Loeliger
2008-01-22 23:51 ` Stephen Rothwell
2008-01-23 14:05 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4797499A.3020506@freescale.com \
--to=jdl@freescale.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).