From: Jochen Friedrich <jochen@scram.de>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
"Kernel, Linux" <linux-kernel@vger.kernel.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCHv2 5/8] [POWERPC] Remove sysdev/commproc.h
Date: Wed, 23 Jan 2008 19:03:59 +0100 [thread overview]
Message-ID: <4797818F.2080603@scram.de> (raw)
In-Reply-To: <83FEE161-D10D-4E21-BDB3-D0B6D49668CE@kernel.crashing.org>
Hi Kumar,
> Do we really need the prototypes you moved into asm/mpc8xx.h here? can
> they just live in platforms/8xx/8xx.h or something like that?
At least drivers/pcmcia/m8xx_pcmcia.c uses the symbol m8xx_pcmcia_ops
which is conditionally defined in platforms/8xx/m8xx_setup.c. However,
this driver currently seems to be broken (doesn't compile neither as
built-in nor as module).
Other drivers that include asm/mpc8xx.c are:
drivers/net/fec.c (the include seems to be obsolete, as according to Kconfig
the driver is only built on MPC52xx platforms)
drivers/net/fec_8xx (unused, depends on non-existant CONFIG_8XX)
drivers/net/fs_enet (i need to check if the include is needed, at all)
I'll have a closer look at this.
Thanks,
Jochen
prev parent reply other threads:[~2008-01-23 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 16:00 [PATCHv2 5/8] [POWERPC] Remove sysdev/commproc.h Jochen Friedrich
2008-01-23 16:06 ` Kumar Gala
2008-01-23 18:03 ` Jochen Friedrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4797818F.2080603@scram.de \
--to=jochen@scram.de \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).