From: Jochen Friedrich <jochen@scram.de>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCHv3 6/7] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c
Date: Fri, 25 Jan 2008 11:27:17 +0100 [thread overview]
Message-ID: <4799B985.70605@scram.de> (raw)
In-Reply-To: <F4B3DC7D-AC57-4C37-8708-5A3E73F5F97C@kernel.crashing.org>
Hi Kumar,
>> drivers/net/fec.c | 8 --------
>> drivers/net/fec.h | 2 +-
>
> asm-m68knommu/commproc.h ?? these are only built on coldfire.
Yes. Here I just removed dead code (commented out using #ifdef on coldfire). Apparently the driver was
used on MPC8xx before or was copied from there but never cleaned up? Maybe this should be a seperate patch?
>> drivers/serial/68360serial.c | 2 +-
>
> I think this is using asm-m68knommu/commproc.h
Oops, that one slipped through :-/.
Thanks,
Jochen
prev parent reply other threads:[~2008-01-25 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 15:19 [PATCHv3 6/7] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c Jochen Friedrich
2008-01-25 9:00 ` Kumar Gala
2008-01-25 10:27 ` Jochen Friedrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4799B985.70605@scram.de \
--to=jochen@scram.de \
--cc=galak@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).