RE: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

RE: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Zhang Wei]

Sorry for wrong sending name of this and next email.

Best Regards,
Wei.=20

> -----Original Message-----
> From: y [mailto:y]=20
> Sent: Thursday, January 31, 2008 3:45 PM
> To: galak@kernel.crashing.org
> Cc: linuxppc-dev@ozlabs.org; Zhang Wei
> Subject: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file
>=20
> From: Zhang Wei <wei.zhang@freescale.com>
>=20
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> ---
>  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
>=20
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts=20
> b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> index 556a9ca..1a0fce5 100644
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> @@ -25,6 +25,7 @@
>  		serial1 =3D &serial1;
>  		pci0 =3D &pci0;
>  		pci1 =3D &pci1;
> +		rapidio0 =3D &rapidio0;
>  	};
> =20
>  	cpus {
> @@ -499,4 +500,16 @@
>  				  0 00100000>;
>  		};
>  	};
> +
> +	rapidio0: rapidio@f80c0000 {
> +		#address-cells =3D <2>;
> +		#size-cells =3D <2>;
> +		compatible =3D "fsl,rapidio-delta";
> +		reg =3D <f80c0000 20000>;
> +		ranges =3D <0 0 c0000000 0 20000000>;
> +		interrupt-parent =3D <&mpic>;
> +		/* err_irq bell_outb_irq bell_inb_irq
> +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq=20
> msg2_rx_irq */
> +		interrupts =3D <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
> +	};
>  };
> --=20
> 1.5.2
>=20
>=20

[PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[y]

From: Zhang Wei <wei.zhang@freescale.com>

Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
---
 arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
index 556a9ca..1a0fce5 100644
--- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -25,6 +25,7 @@
 		serial1 = &serial1;
 		pci0 = &pci0;
 		pci1 = &pci1;
+		rapidio0 = &rapidio0;
 	};
 
 	cpus {
@@ -499,4 +500,16 @@
 				  0 00100000>;
 		};
 	};
+
+	rapidio0: rapidio@f80c0000 {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		compatible = "fsl,rapidio-delta";
+		reg = <f80c0000 20000>;
+		ranges = <0 0 c0000000 0 20000000>;
+		interrupt-parent = <&mpic>;
+		/* err_irq bell_outb_irq bell_inb_irq
+			msg1_tx_irq msg1_rx_irq	msg2_tx_irq msg2_rx_irq */
+		interrupts = <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
+	};
 };
-- 
1.5.2

[PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Zhang Wei]

Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
---
 arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
index 556a9ca..1a0fce5 100644
--- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -25,6 +25,7 @@
 		serial1 = &serial1;
 		pci0 = &pci0;
 		pci1 = &pci1;
+		rapidio0 = &rapidio0;
 	};
 
 	cpus {
@@ -499,4 +500,16 @@
 				  0 00100000>;
 		};
 	};
+
+	rapidio0: rapidio@f80c0000 {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		compatible = "fsl,rapidio-delta";
+		reg = <f80c0000 20000>;
+		ranges = <0 0 c0000000 0 20000000>;
+		interrupt-parent = <&mpic>;
+		/* err_irq bell_outb_irq bell_inb_irq
+			msg1_tx_irq msg1_rx_irq	msg2_tx_irq msg2_rx_irq */
+		interrupts = <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
+	};
 };
-- 
1.5.2

[PATCH 2/2] Add RapidIO node probing into MPC86xx_HPCN board id table.

[Zhang Wei]

Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
---
 arch/powerpc/platforms/86xx/mpc86xx_hpcn.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c b/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c
index cfbe8c5..4a3e421 100644
--- a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c
+++ b/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c
@@ -215,6 +215,7 @@ mpc86xx_time_init(void)
 
 static __initdata struct of_device_id of_bus_ids[] = {
 	{ .compatible = "simple-bus", },
+	{ .compatible = "fsl,rapidio-delta", },
 	{},
 };
 
-- 
1.5.2

Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Jon Loeliger]

Zhang Wei wrote:
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> ---
>  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> index 556a9ca..1a0fce5 100644
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> @@ -25,6 +25,7 @@
>  		serial1 = &serial1;
>  		pci0 = &pci0;
>  		pci1 = &pci1;
> +		rapidio0 = &rapidio0;
>  	};
>  
>  	cpus {
> @@ -499,4 +500,16 @@
>  				  0 00100000>;
>  		};
>  	};
> +
> +	rapidio0: rapidio@f80c0000 {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		compatible = "fsl,rapidio-delta";
> +		reg = <f80c0000 20000>;
> +		ranges = <0 0 c0000000 0 20000000>;
> +		interrupt-parent = <&mpic>;
> +		/* err_irq bell_outb_irq bell_inb_irq
> +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq msg2_rx_irq */
> +		interrupts = <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
> +	};
>  };

The 8641 DTS file has been converted to /dts-v1/ format now.
Please rewrite this patch with explicit hex numbers for
addresses, even if 0x0, and decimal for IRQs.

Thanks,
jdl

Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Jon Loeliger]

Zhang Wei wrote:
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> ---
>  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> index 556a9ca..1a0fce5 100644
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts

> @@ -499,4 +500,16 @@
>  				  0 00100000>;
>  		};
>  	};
> +
> +	rapidio0: rapidio@f80c0000 {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		compatible = "fsl,rapidio-delta";
> +		reg = <f80c0000 20000>;
> +		ranges = <0 0 c0000000 0 20000000>;
> +		interrupt-parent = <&mpic>;
> +		/* err_irq bell_outb_irq bell_inb_irq
> +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq msg2_rx_irq */
> +		interrupts = <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
> +	};
>  };

Have updates to the booting-without-of.txt file for
been made or proposed for the RapidIO node definition?

jdl

RE: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Zhang Wei]

Hi, Jon,=20

> -----Original Message-----
> From: Loeliger Jon=20
>=20
> Zhang Wei wrote:
> > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > ---
> >  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
> >  1 files changed, 13 insertions(+), 0 deletions(-)
> >=20
> > diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts=20
> b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > index 556a9ca..1a0fce5 100644
> > --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > @@ -25,6 +25,7 @@
> >  		serial1 =3D &serial1;
> >  		pci0 =3D &pci0;
> >  		pci1 =3D &pci1;
> > +		rapidio0 =3D &rapidio0;
> >  	};
> > =20
> >  	cpus {
> > @@ -499,4 +500,16 @@
> >  				  0 00100000>;
> >  		};
> >  	};
> > +
> > +	rapidio0: rapidio@f80c0000 {
> > +		#address-cells =3D <2>;
> > +		#size-cells =3D <2>;
> > +		compatible =3D "fsl,rapidio-delta";
> > +		reg =3D <f80c0000 20000>;
> > +		ranges =3D <0 0 c0000000 0 20000000>;
> > +		interrupt-parent =3D <&mpic>;
> > +		/* err_irq bell_outb_irq bell_inb_irq
> > +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq=20
> msg2_rx_irq */
> > +		interrupts =3D <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
> > +	};
> >  };
>=20
> The 8641 DTS file has been converted to /dts-v1/ format now.
> Please rewrite this patch with explicit hex numbers for
> addresses, even if 0x0, and decimal for IRQs.
>=20

Thanks! I'm dropped by fashion. :) I'll re-do them.

Cheers!
Wei.

RE: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Zhang Wei]

=20

> -----Original Message-----
> From: Loeliger Jon=20
>=20
> Zhang Wei wrote:
> > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > ---
> >  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
> >  1 files changed, 13 insertions(+), 0 deletions(-)
> >=20
> > diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts=20
> b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > index 556a9ca..1a0fce5 100644
> > --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
>=20
> > @@ -499,4 +500,16 @@
> >  				  0 00100000>;
> >  		};
> >  	};
> > +
> > +	rapidio0: rapidio@f80c0000 {
> > +		#address-cells =3D <2>;
> > +		#size-cells =3D <2>;
> > +		compatible =3D "fsl,rapidio-delta";
> > +		reg =3D <f80c0000 20000>;
> > +		ranges =3D <0 0 c0000000 0 20000000>;
> > +		interrupt-parent =3D <&mpic>;
> > +		/* err_irq bell_outb_irq bell_inb_irq
> > +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq=20
> msg2_rx_irq */
> > +		interrupts =3D <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
> > +	};
> >  };
>=20
> Have updates to the booting-without-of.txt file for
> been made or proposed for the RapidIO node definition?
>=20
I remember Kumar has a patch for RapidIO node of booting-without-of.txt, =
is it?

Cheers!
Wei.

Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Kumar Gala]

On Jan 31, 2008, at 9:21 PM, Zhang Wei wrote:

>
>
>> -----Original Message-----
>> From: Loeliger Jon
>>
>> Zhang Wei wrote:
>>> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
>>> ---
>>> arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
>>> 1 files changed, 13 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
>> b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
>>> index 556a9ca..1a0fce5 100644
>>> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
>>> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
>>
>>> @@ -499,4 +500,16 @@
>>> 				  0 00100000>;
>>> 		};
>>> 	};
>>> +
>>> +	rapidio0: rapidio@f80c0000 {
>>> +		#address-cells = <2>;
>>> +		#size-cells = <2>;
>>> +		compatible = "fsl,rapidio-delta";
>>> +		reg = <f80c0000 20000>;
>>> +		ranges = <0 0 c0000000 0 20000000>;
>>> +		interrupt-parent = <&mpic>;
>>> +		/* err_irq bell_outb_irq bell_inb_irq
>>> +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq
>> msg2_rx_irq */
>>> +		interrupts = <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
>>> +	};
>>> };
>>
>> Have updates to the booting-without-of.txt file for
>> been made or proposed for the RapidIO node definition?
>>
> I remember Kumar has a patch for RapidIO node of booting-without- 
> of.txt, is it?

I do.. I'll post it and update the .dts patch once I sort through all  
the patches.

- k

RE: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Zhang Wei]

Hi, Jon,=20

> -----Original Message-----
> From: Loeliger Jon=20
>=20
> Zhang Wei wrote:
> > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > ---
> >  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
> >  1 files changed, 13 insertions(+), 0 deletions(-)
> >=20
> > diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts=20
> b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > index 556a9ca..1a0fce5 100644
> > --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > @@ -25,6 +25,7 @@
> >  		serial1 =3D &serial1;
> >  		pci0 =3D &pci0;
> >  		pci1 =3D &pci1;
> > +		rapidio0 =3D &rapidio0;
> >  	};
> > =20
> >  	cpus {
> > @@ -499,4 +500,16 @@
> >  				  0 00100000>;
> >  		};
> >  	};
> > +
> > +	rapidio0: rapidio@f80c0000 {
> > +		#address-cells =3D <2>;
> > +		#size-cells =3D <2>;
> > +		compatible =3D "fsl,rapidio-delta";
> > +		reg =3D <f80c0000 20000>;
> > +		ranges =3D <0 0 c0000000 0 20000000>;
> > +		interrupt-parent =3D <&mpic>;
> > +		/* err_irq bell_outb_irq bell_inb_irq
> > +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq=20
> msg2_rx_irq */
> > +		interrupts =3D <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
> > +	};
> >  };
>=20
> The 8641 DTS file has been converted to /dts-v1/ format now.
> Please rewrite this patch with explicit hex numbers for
> addresses, even if 0x0, and decimal for IRQs.
>=20
I have seen other nodes in mpc8641_hpcn.dts still use old style.
 Is it better to create an another new patch for correcting the style =
all?

Cheers!
Wei

Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

[Jon Loeliger]

So, like, the other day "Zhang Wei" mumbled:
> > 
> > The 8641 DTS file has been converted to /dts-v1/ format now.
> > Please rewrite this patch with explicit hex numbers for
> > addresses, even if 0x0, and decimal for IRQs.
>
> I have seen other nodes in mpc8641_hpcn.dts still use old style.
>  Is it better to create an another new patch for correcting the style all?

The file as to be all one format or the other, it can not be mixed.

Kumar applied my patches to convert all the 86xx FSL boards to /dts-v1/
and they have gone into Paul's and Linus' mainline already.

If another old style node goes by, we should all gang up on it! :-)

jdl