From: Jeff Garzik <jgarzik@pobox.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: netdev@vger.kernel.org, Li Yang <leoli@freescale.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal
Date: Fri, 01 Feb 2008 13:40:34 -0500 [thread overview]
Message-ID: <47A367A2.10706@pobox.com> (raw)
In-Reply-To: <20080201132248.GA1790@localhost.localdomain>
Anton Vorontsov wrote:
> - uccf should be set to NULL to not double-free memory on
> subsequent calls;
> - ind_hash_q and group_hash_q lists should be initialized in the
> probe() function, instead of struct_init() (called by open()),
> otherwise there will be an oops if ucc_geth_driver removed
> prior 'ifconfig ethX up';
> - add unregister_netdev();
> - reorder geth_remove() steps.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>
> Hi Li,
>
> You kinda promised that these two patches would hit 2.6.25... ;-)
>
> I've rebased the patches so they apply cleanly on the current tree.
>
> Thanks,
>
> drivers/net/ucc_geth.c | 17 ++++++++++-------
> 1 files changed, 10 insertions(+), 7 deletions(-)
applied 1-2
prev parent reply other threads:[~2008-02-01 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 13:22 [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal Anton Vorontsov
2008-02-01 18:40 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A367A2.10706@pobox.com \
--to=jgarzik@pobox.com \
--cc=avorontsov@ru.mvista.com \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).