From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 5820DDDFE7 for ; Sat, 2 Feb 2008 05:40:47 +1100 (EST) Message-ID: <47A367A2.10706@pobox.com> Date: Fri, 01 Feb 2008 13:40:34 -0500 From: Jeff Garzik MIME-Version: 1.0 To: Anton Vorontsov Subject: Re: [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal References: <20080201132248.GA1790@localhost.localdomain> In-Reply-To: <20080201132248.GA1790@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: netdev@vger.kernel.org, Li Yang , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Anton Vorontsov wrote: > - uccf should be set to NULL to not double-free memory on > subsequent calls; > - ind_hash_q and group_hash_q lists should be initialized in the > probe() function, instead of struct_init() (called by open()), > otherwise there will be an oops if ucc_geth_driver removed > prior 'ifconfig ethX up'; > - add unregister_netdev(); > - reorder geth_remove() steps. > > Signed-off-by: Anton Vorontsov > --- > > Hi Li, > > You kinda promised that these two patches would hit 2.6.25... ;-) > > I've rebased the patches so they apply cleanly on the current tree. > > Thanks, > > drivers/net/ucc_geth.c | 17 ++++++++++------- > 1 files changed, 10 insertions(+), 7 deletions(-) applied 1-2