* [PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock
@ 2008-02-01 20:36 Valentine Barshak
2008-02-04 14:08 ` Valentine Barshak
0 siblings, 1 reply; 3+ messages in thread
From: Valentine Barshak @ 2008-02-01 20:36 UTC (permalink / raw)
To: linuxppc-dev
The include/asm-powerpc/dcr-native.h declares extern spinlock_t dcr_ind_lock,
but it's actually isn't defined. This patch adds a missing dcr_ind_lock.
Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
arch/powerpc/sysdev/dcr.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff -pruN linux-2.6.orig/arch/powerpc/sysdev/dcr.c linux-2.6/arch/powerpc/sysdev/dcr.c
--- linux-2.6.orig/arch/powerpc/sysdev/dcr.c 2008-01-31 16:58:32.000000000 +0300
+++ linux-2.6/arch/powerpc/sysdev/dcr.c 2008-02-01 23:17:35.000000000 +0300
@@ -137,5 +137,6 @@ void dcr_unmap(dcr_host_t host, unsigned
h.token = NULL;
}
EXPORT_SYMBOL_GPL(dcr_unmap);
-
-#endif /* !defined(CONFIG_PPC_DCR_NATIVE) */
+#else /* defined(CONFIG_PPC_DCR_NATIVE) */
+spinlock_t dcr_ind_lock;
+#endif /* !defined(CONFIG_PPC_DCR_NATIVE) */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock
2008-02-01 20:36 [PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock Valentine Barshak
@ 2008-02-04 14:08 ` Valentine Barshak
2008-02-04 14:57 ` Valentine Barshak
0 siblings, 1 reply; 3+ messages in thread
From: Valentine Barshak @ 2008-02-04 14:08 UTC (permalink / raw)
To: linuxppc-dev
Oops, sorry, please discard this one.
DEFINE_SPINLOCK should be used here.
Valentine Barshak wrote:
> The include/asm-powerpc/dcr-native.h declares extern spinlock_t dcr_ind_lock,
> but it's actually isn't defined. This patch adds a missing dcr_ind_lock.
>
> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
> ---
> arch/powerpc/sysdev/dcr.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff -pruN linux-2.6.orig/arch/powerpc/sysdev/dcr.c linux-2.6/arch/powerpc/sysdev/dcr.c
> --- linux-2.6.orig/arch/powerpc/sysdev/dcr.c 2008-01-31 16:58:32.000000000 +0300
> +++ linux-2.6/arch/powerpc/sysdev/dcr.c 2008-02-01 23:17:35.000000000 +0300
> @@ -137,5 +137,6 @@ void dcr_unmap(dcr_host_t host, unsigned
> h.token = NULL;
> }
> EXPORT_SYMBOL_GPL(dcr_unmap);
> -
> -#endif /* !defined(CONFIG_PPC_DCR_NATIVE) */
> +#else /* defined(CONFIG_PPC_DCR_NATIVE) */
> +spinlock_t dcr_ind_lock;
> +#endif /* !defined(CONFIG_PPC_DCR_NATIVE) */
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock
2008-02-04 14:08 ` Valentine Barshak
@ 2008-02-04 14:57 ` Valentine Barshak
0 siblings, 0 replies; 3+ messages in thread
From: Valentine Barshak @ 2008-02-04 14:57 UTC (permalink / raw)
To: linuxppc-dev
The include/asm-powerpc/dcr-native.h declares extern spinlock_t dcr_ind_lock;
but it's actually isn't defined. This patch adds a missing dcr_ind_lock.
Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
arch/powerpc/sysdev/dcr.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff -pruN linux-2.6.orig/arch/powerpc/sysdev/dcr.c linux-2.6/arch/powerpc/sysdev/dcr.c
--- linux-2.6.orig/arch/powerpc/sysdev/dcr.c 2008-01-31 16:58:32.000000000 +0300
+++ linux-2.6/arch/powerpc/sysdev/dcr.c 2008-02-01 23:17:35.000000000 +0300
@@ -137,5 +137,6 @@ void dcr_unmap(dcr_host_t host, unsigned
h.token = NULL;
}
EXPORT_SYMBOL_GPL(dcr_unmap);
-
-#endif /* !defined(CONFIG_PPC_DCR_NATIVE) */
+#else /* defined(CONFIG_PPC_DCR_NATIVE) */
+DEFINE_SPINLOCK(dcr_ind_lock);
+#endif /* !defined(CONFIG_PPC_DCR_NATIVE) */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-04 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-01 20:36 [PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock Valentine Barshak
2008-02-04 14:08 ` Valentine Barshak
2008-02-04 14:57 ` Valentine Barshak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).