From: Pavel Kiryukhin <pkiryukhin@ru.mvista.com>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] booting-without-of: add Xilinx uart 16550.
Date: Fri, 15 Feb 2008 20:41:03 +0300 [thread overview]
Message-ID: <47B5CEAF.8030705@ru.mvista.com> (raw)
In-Reply-To: <20080215170844.9D21610081@mail40-dub.bigfish.com>
Stephen Neuendorffer wrote:
>> + - reg-shift : registers offset shift (standard uart_port
> field).
>> + Property is optional if regshift is zero.
>
> I was hoping to get an idea of what is required here, or when I might
> use it?
>
> It looks like the ARCH=ppc code instantiates this with a reg-shift of
> 2... Is this the expected value?
Yes, reg-shift = 2 should be set for Xilinx 16550 uart.
Should I add this to patch?
BTW regshift=2 is hardcoded for uartlite.
> When would it be not zero? or not
> two?
Sorry, it seems I don't follow here.
--
Regards,
Pavel
next prev parent reply other threads:[~2008-02-15 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 13:40 [PATCH] booting-without-of: add Xilinx uart 16550 Pavel Kiryukhin
2008-02-15 17:08 ` Stephen Neuendorffer
2008-02-15 17:41 ` Pavel Kiryukhin [this message]
2008-02-15 17:46 ` Stephen Neuendorffer
2008-02-15 18:34 ` Milton Miller
2008-02-15 18:38 ` Grant Likely
2008-02-15 18:56 ` Sergei Shtylyov
2008-02-15 19:02 ` Grant Likely
2008-02-15 19:14 ` Sergei Shtylyov
2008-02-15 19:33 ` Grant Likely
2008-02-15 21:40 ` Stephen Neuendorffer
2008-02-18 19:47 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B5CEAF.8030705@ru.mvista.com \
--to=pkiryukhin@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=stephen.neuendorffer@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).