[PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[Anton Vorontsov]

Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
Another option would be to convert USB_EHCI_FSL to verbose bool,
but I presume EHCI_FSL is purposely made silent.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/usb/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index d97b16b..33da056 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -72,7 +72,7 @@ config USB_EHCI_FSL
 	bool
 	depends on USB_EHCI_HCD
 	select USB_EHCI_ROOT_HUB_TT
-	default y if MPC834x || PPC_MPC831x
+	default y if MPC834x || PPC_MPC831x || PPC_MPC837x
 	---help---
 	  Variation of ARC USB block used in some Freescale chips.
 
-- 
1.5.2.2

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[Scott Wood]

Anton Vorontsov wrote:
> Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
> Another option would be to convert USB_EHCI_FSL to verbose bool,
> but I presume EHCI_FSL is purposely made silent.

I think making it verbose bool would be better.

-Scott

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[Kumar Gala]

On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote:

> Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
> Another option would be to convert USB_EHCI_FSL to verbose bool,
> but I presume EHCI_FSL is purposely made silent.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> drivers/usb/host/Kconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index d97b16b..33da056 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -72,7 +72,7 @@ config USB_EHCI_FSL
> 	bool
> 	depends on USB_EHCI_HCD
> 	select USB_EHCI_ROOT_HUB_TT
> -	default y if MPC834x || PPC_MPC831x
> +	default y if MPC834x || PPC_MPC831x || PPC_MPC837x

Can we just change this to FSL_SOC

- k

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[Scott Wood]

Kumar Gala wrote:
> On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote:
> 
>> Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
>> Another option would be to convert USB_EHCI_FSL to verbose bool,
>> but I presume EHCI_FSL is purposely made silent.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>> drivers/usb/host/Kconfig |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index d97b16b..33da056 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -72,7 +72,7 @@ config USB_EHCI_FSL
>> 	bool
>> 	depends on USB_EHCI_HCD
>> 	select USB_EHCI_ROOT_HUB_TT
>> -	default y if MPC834x || PPC_MPC831x
>> +	default y if MPC834x || PPC_MPC831x || PPC_MPC837x
> 
> Can we just change this to FSL_SOC

Why do you want to bloat all freescale kernels, even on chips that don't 
have this hardware?

There are very few cases where default y is justified.  This isn't one 
of them.

-Scott

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[Anton Vorontsov]

On Thu, Feb 21, 2008 at 01:58:18PM -0600, Kumar Gala wrote:
> 
> On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote:
> 
> >Without this patch it's impossible to select ehci-fsl on PPC_MPC837x.
> >Another option would be to convert USB_EHCI_FSL to verbose bool,
> >but I presume EHCI_FSL is purposely made silent.
> >
> >Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> >---
> >drivers/usb/host/Kconfig |    2 +-
> >1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> >index d97b16b..33da056 100644
> >--- a/drivers/usb/host/Kconfig
> >+++ b/drivers/usb/host/Kconfig
> >@@ -72,7 +72,7 @@ config USB_EHCI_FSL
> >	bool
> >	depends on USB_EHCI_HCD
> >	select USB_EHCI_ROOT_HUB_TT
> >-	default y if MPC834x || PPC_MPC831x
> >+	default y if MPC834x || PPC_MPC831x || PPC_MPC837x
> 
> Can we just change this to FSL_SOC

Easily. But not "default y"... "depends on" instead, ok?
There are plenty of FSL chips without EHCI built-in, so with
default y we'll enable it wrongly.

- - - -
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: [USB POWERPC] ehci-fsl: handles other freescale processors

This patch converts USB_EHCI_FSL config option into the verbose
bool, so we'll able to select it for other freescale processors
with built-in EHCI controller.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/usb/host/Kconfig |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index d97b16b..bf8be2a 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -69,10 +69,9 @@ config USB_EHCI_BIG_ENDIAN_DESC
 	default y
 
 config USB_EHCI_FSL
-	bool
-	depends on USB_EHCI_HCD
+	bool "Support for Freescale on-chip EHCI USB controller"
+	depends on USB_EHCI_HCD && FSL_SOC
 	select USB_EHCI_ROOT_HUB_TT
-	default y if MPC834x || PPC_MPC831x
 	---help---
 	  Variation of ARC USB block used in some Freescale chips.
 
-- 
1.5.2.2

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[Peter Korsgaard]

>>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes:

Hi,

 Anton>  config USB_EHCI_FSL
 Anton> -	bool
 Anton> -	depends on USB_EHCI_HCD
 Anton> +	bool "Support for Freescale on-chip EHCI USB controller"
 Anton> +	depends on USB_EHCI_HCD && FSL_SOC
 Anton>  	select USB_EHCI_ROOT_HUB_TT
 Anton> -	default y if MPC834x || PPC_MPC831x

Notice that I have a patch in the USB queue which fixes up the MPC834x
symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply.

-- 
Bye, Peter Korsgaard

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

[Peter Korsgaard]

On Fri, Feb 22, 2008 at 2:36 AM, Peter Korsgaard <jacmet@sunsite.dk> wrote:

>  Notice that I have a patch in the USB queue which fixes up the MPC834x
>  symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply.

Never mind, Greg fixed it.

-- 
Bye, Peter Korsgaard