From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 4D6C9DDEBC for ; Fri, 22 Feb 2008 07:09:01 +1100 (EST) Message-ID: <47BDDA70.2060700@freescale.com> Date: Thu, 21 Feb 2008 14:09:20 -0600 From: Scott Wood MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y References: <20080221195021.GC12896@localhost.localdomain> <9AD13D2E-B57F-4F19-B89C-C8A83157E0F2@kernel.crashing.org> In-Reply-To: <9AD13D2E-B57F-4F19-B89C-C8A83157E0F2@kernel.crashing.org> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linuxppc-dev@ozlabs.org, linux-usb@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala wrote: > On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote: > >> Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. >> Another option would be to convert USB_EHCI_FSL to verbose bool, >> but I presume EHCI_FSL is purposely made silent. >> >> Signed-off-by: Anton Vorontsov >> --- >> drivers/usb/host/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >> index d97b16b..33da056 100644 >> --- a/drivers/usb/host/Kconfig >> +++ b/drivers/usb/host/Kconfig >> @@ -72,7 +72,7 @@ config USB_EHCI_FSL >> bool >> depends on USB_EHCI_HCD >> select USB_EHCI_ROOT_HUB_TT >> - default y if MPC834x || PPC_MPC831x >> + default y if MPC834x || PPC_MPC831x || PPC_MPC837x > > Can we just change this to FSL_SOC Why do you want to bloat all freescale kernels, even on chips that don't have this hardware? There are very few cases where default y is justified. This isn't one of them. -Scott