* [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y @ 2008-02-21 19:50 Anton Vorontsov 2008-02-21 19:55 ` Scott Wood 2008-02-21 19:58 ` Kumar Gala 0 siblings, 2 replies; 7+ messages in thread From: Anton Vorontsov @ 2008-02-21 19:50 UTC (permalink / raw) To: linuxppc-dev; +Cc: linux-usb Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. Another option would be to convert USB_EHCI_FSL to verbose bool, but I presume EHCI_FSL is purposely made silent. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- drivers/usb/host/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index d97b16b..33da056 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -72,7 +72,7 @@ config USB_EHCI_FSL bool depends on USB_EHCI_HCD select USB_EHCI_ROOT_HUB_TT - default y if MPC834x || PPC_MPC831x + default y if MPC834x || PPC_MPC831x || PPC_MPC837x ---help--- Variation of ARC USB block used in some Freescale chips. -- 1.5.2.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y 2008-02-21 19:50 [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y Anton Vorontsov @ 2008-02-21 19:55 ` Scott Wood 2008-02-21 19:58 ` Kumar Gala 1 sibling, 0 replies; 7+ messages in thread From: Scott Wood @ 2008-02-21 19:55 UTC (permalink / raw) To: Anton Vorontsov; +Cc: linuxppc-dev, linux-usb Anton Vorontsov wrote: > Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. > Another option would be to convert USB_EHCI_FSL to verbose bool, > but I presume EHCI_FSL is purposely made silent. I think making it verbose bool would be better. -Scott ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y 2008-02-21 19:50 [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y Anton Vorontsov 2008-02-21 19:55 ` Scott Wood @ 2008-02-21 19:58 ` Kumar Gala 2008-02-21 20:09 ` Scott Wood 2008-02-21 20:30 ` Anton Vorontsov 1 sibling, 2 replies; 7+ messages in thread From: Kumar Gala @ 2008-02-21 19:58 UTC (permalink / raw) To: Anton Vorontsov; +Cc: linuxppc-dev, linux-usb On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote: > Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. > Another option would be to convert USB_EHCI_FSL to verbose bool, > but I presume EHCI_FSL is purposely made silent. > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > --- > drivers/usb/host/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index d97b16b..33da056 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -72,7 +72,7 @@ config USB_EHCI_FSL > bool > depends on USB_EHCI_HCD > select USB_EHCI_ROOT_HUB_TT > - default y if MPC834x || PPC_MPC831x > + default y if MPC834x || PPC_MPC831x || PPC_MPC837x Can we just change this to FSL_SOC - k ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y 2008-02-21 19:58 ` Kumar Gala @ 2008-02-21 20:09 ` Scott Wood 2008-02-21 20:30 ` Anton Vorontsov 1 sibling, 0 replies; 7+ messages in thread From: Scott Wood @ 2008-02-21 20:09 UTC (permalink / raw) To: Kumar Gala; +Cc: linuxppc-dev, linux-usb Kumar Gala wrote: > On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote: > >> Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. >> Another option would be to convert USB_EHCI_FSL to verbose bool, >> but I presume EHCI_FSL is purposely made silent. >> >> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> >> --- >> drivers/usb/host/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >> index d97b16b..33da056 100644 >> --- a/drivers/usb/host/Kconfig >> +++ b/drivers/usb/host/Kconfig >> @@ -72,7 +72,7 @@ config USB_EHCI_FSL >> bool >> depends on USB_EHCI_HCD >> select USB_EHCI_ROOT_HUB_TT >> - default y if MPC834x || PPC_MPC831x >> + default y if MPC834x || PPC_MPC831x || PPC_MPC837x > > Can we just change this to FSL_SOC Why do you want to bloat all freescale kernels, even on chips that don't have this hardware? There are very few cases where default y is justified. This isn't one of them. -Scott ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y 2008-02-21 19:58 ` Kumar Gala 2008-02-21 20:09 ` Scott Wood @ 2008-02-21 20:30 ` Anton Vorontsov 2008-02-22 1:36 ` Peter Korsgaard 1 sibling, 1 reply; 7+ messages in thread From: Anton Vorontsov @ 2008-02-21 20:30 UTC (permalink / raw) To: Kumar Gala; +Cc: linuxppc-dev, linux-usb On Thu, Feb 21, 2008 at 01:58:18PM -0600, Kumar Gala wrote: > > On Feb 21, 2008, at 1:50 PM, Anton Vorontsov wrote: > > >Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. > >Another option would be to convert USB_EHCI_FSL to verbose bool, > >but I presume EHCI_FSL is purposely made silent. > > > >Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > >--- > >drivers/usb/host/Kconfig | 2 +- > >1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > >index d97b16b..33da056 100644 > >--- a/drivers/usb/host/Kconfig > >+++ b/drivers/usb/host/Kconfig > >@@ -72,7 +72,7 @@ config USB_EHCI_FSL > > bool > > depends on USB_EHCI_HCD > > select USB_EHCI_ROOT_HUB_TT > >- default y if MPC834x || PPC_MPC831x > >+ default y if MPC834x || PPC_MPC831x || PPC_MPC837x > > Can we just change this to FSL_SOC Easily. But not "default y"... "depends on" instead, ok? There are plenty of FSL chips without EHCI built-in, so with default y we'll enable it wrongly. - - - - From: Anton Vorontsov <avorontsov@ru.mvista.com> Subject: [USB POWERPC] ehci-fsl: handles other freescale processors This patch converts USB_EHCI_FSL config option into the verbose bool, so we'll able to select it for other freescale processors with built-in EHCI controller. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- drivers/usb/host/Kconfig | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index d97b16b..bf8be2a 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -69,10 +69,9 @@ config USB_EHCI_BIG_ENDIAN_DESC default y config USB_EHCI_FSL - bool - depends on USB_EHCI_HCD + bool "Support for Freescale on-chip EHCI USB controller" + depends on USB_EHCI_HCD && FSL_SOC select USB_EHCI_ROOT_HUB_TT - default y if MPC834x || PPC_MPC831x ---help--- Variation of ARC USB block used in some Freescale chips. -- 1.5.2.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y 2008-02-21 20:30 ` Anton Vorontsov @ 2008-02-22 1:36 ` Peter Korsgaard 2008-02-22 1:52 ` Peter Korsgaard 0 siblings, 1 reply; 7+ messages in thread From: Peter Korsgaard @ 2008-02-22 1:36 UTC (permalink / raw) To: avorontsov; +Cc: linuxppc-dev, linux-usb >>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes: Hi, Anton> config USB_EHCI_FSL Anton> - bool Anton> - depends on USB_EHCI_HCD Anton> + bool "Support for Freescale on-chip EHCI USB controller" Anton> + depends on USB_EHCI_HCD && FSL_SOC Anton> select USB_EHCI_ROOT_HUB_TT Anton> - default y if MPC834x || PPC_MPC831x Notice that I have a patch in the USB queue which fixes up the MPC834x symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y 2008-02-22 1:36 ` Peter Korsgaard @ 2008-02-22 1:52 ` Peter Korsgaard 0 siblings, 0 replies; 7+ messages in thread From: Peter Korsgaard @ 2008-02-22 1:52 UTC (permalink / raw) To: avorontsov; +Cc: linuxppc-dev, linux-usb On Fri, Feb 22, 2008 at 2:36 AM, Peter Korsgaard <jacmet@sunsite.dk> wrote: > Notice that I have a patch in the USB queue which fixes up the MPC834x > symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply. Never mind, Greg fixed it. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-02-22 1:52 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-02-21 19:50 [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y Anton Vorontsov 2008-02-21 19:55 ` Scott Wood 2008-02-21 19:58 ` Kumar Gala 2008-02-21 20:09 ` Scott Wood 2008-02-21 20:30 ` Anton Vorontsov 2008-02-22 1:36 ` Peter Korsgaard 2008-02-22 1:52 ` Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).