From: Badari Pulavarty <pbadari@us.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, Nathan Lynch <ntl@pobox.com>
Subject: Re: [PATCH 3/3] ppc64-specific memory notifier support
Date: Fri, 29 Feb 2008 19:01:35 -0800 [thread overview]
Message-ID: <47C8C70F.70204@us.ibm.com> (raw)
In-Reply-To: <20080301135123.262bfdb0.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> On Fri, 29 Feb 2008 09:47:16 -0800 Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
>> Here is the latest for review. (just to make sure I didn't miss
>> anything).
>>
>
> Sorry I didn't review the previous ones ... just a small thing.
>
>
>> + type = of_get_property(np, "device_type", NULL);
>>
>
> To use the of_ accessors, you need to include linux/of.h (currently
> asm/prom.h include linux/of.h, but that may not always be true). In
> fact, I think you don't even need asm/prom.h.
>
>
Yes. linux/of.h is enough. Thank you for pointing it out.
Thanks,
Badari
next prev parent reply other threads:[~2008-03-01 3:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 16:43 [PATCH 0/3] hotplug memory remove updates Badari Pulavarty
2008-02-28 16:44 ` [PATCH 1/3] ppc64-specific remove htab bolted mapping support Badari Pulavarty
2008-02-28 16:45 ` [PATCH 2/3] generic __remove_pages() support Badari Pulavarty
2008-02-28 16:46 ` [PATCH 3/3] ppc64-specific memory notifier support Badari Pulavarty
2008-02-28 17:20 ` Nathan Lynch
2008-02-28 18:57 ` Badari Pulavarty
2008-02-29 0:11 ` Michael Ellerman
2008-02-29 0:39 ` Nathan Lynch
2008-02-29 1:03 ` Michael Ellerman
2008-02-29 17:47 ` Badari Pulavarty
2008-03-01 2:51 ` Stephen Rothwell
2008-03-01 3:01 ` Badari Pulavarty [this message]
2008-03-03 0:49 ` Michael Ellerman
2008-02-29 17:56 ` [RFC] updating lmb.memory information for hot mem add/remove Badari Pulavarty
2008-03-01 1:12 ` Badari Pulavarty
2008-03-01 1:44 ` David Miller
2008-03-01 3:06 ` Badari Pulavarty
2008-02-29 1:39 ` [PATCH 0/3] hotplug memory remove updates Nathan Lynch
2008-02-29 2:19 ` Geoff Levand
2008-02-29 19:15 ` Nathan Lynch
2008-02-29 4:51 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C8C70F.70204@us.ibm.com \
--to=pbadari@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).