From: Jeff Garzik <jeff@garzik.org>
To: Stefan Roese <sr@denx.de>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] net: NEWEMAC: Support for Pause packets in EMAC driver
Date: Mon, 17 Mar 2008 08:08:35 -0400 [thread overview]
Message-ID: <47DE5F43.80604@garzik.org> (raw)
In-Reply-To: <1205488348-22536-1-git-send-email-sr@denx.de>
Stefan Roese wrote:
> From: Pravin M. Bathija <pbathija@amcc.com>
>
> Problem Description and Fix
> ---------------------------
> When a pause packet(with destination as reserved Multicast address) is
> received by the EMAC hardware to control the flow of frames being
> transmitted by it, it is dropped by the hardware unless the reserved
> Multicast address is hashed in to the GAHT[1-4] registers. This code fix
> adds the default reserved multicast address to the GAHT[1-4] registers
> in the EMAC(s) present on the chip. The flow control with Pause packets
> will only work if the following register bits are programmed in EMAC:
> EMACx_MR1[APP] = 1
> EMACx_RMR[BAE] = 1
> EMACx_RMR[MAE] = 1
>
> Behavior that may be observed in a running system
> -------------------------------------------------
> A host transferring data from a PPC based system may send a Pause packet
> to the PPC EMAC requesting it to slow down the flow of packets. If the
> default reserved multicast MAC address is not programmed into the
> GAHT[1-4] registers this Pause packet will be dropped by PPC EMAC and no
> Flow Control will be done.
>
> Signed-off-by: Pravin M. Bathija <pbathija@amcc.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> drivers/net/ibm_newemac/core.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
applied
next prev parent reply other threads:[~2008-03-17 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 9:52 [PATCH] net: NEWEMAC: Support for Pause packets in EMAC driver Stefan Roese
2008-03-17 12:08 ` Jeff Garzik [this message]
2008-03-17 21:25 ` Benjamin Herrenschmidt
2008-03-17 21:26 ` Benjamin Herrenschmidt
2008-03-17 21:43 ` Josh Boyer
2008-03-17 21:52 ` Benjamin Herrenschmidt
2008-03-17 22:31 ` Jeff Garzik
2008-03-17 23:55 ` Benjamin Herrenschmidt
2008-03-18 1:08 ` Josh Boyer
2008-03-18 2:41 ` Benjamin Herrenschmidt
2008-03-18 3:56 ` Josh Boyer
2008-03-18 4:06 ` Jeff Garzik
2008-03-18 5:35 ` Benjamin Herrenschmidt
2008-03-18 14:21 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DE5F43.80604@garzik.org \
--to=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).