From: Thomas Klein <osstklei@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jeff@garzik.org, themann@de.ibm.com, netdev@vger.kernel.org,
hering2@de.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, raisch@de.ibm.com,
stefan.roscher@de.ibm.com, stable@kernel.org
Subject: Re: [PATCH] ehea: Fix IPv6 support
Date: Tue, 25 Mar 2008 16:41:04 +0100 [thread overview]
Message-ID: <47E91D10.5060607@de.ibm.com> (raw)
In-Reply-To: <20080320145456.f0b6d101.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Wed, 19 Mar 2008 13:55:43 +0100
> Thomas Klein <osstklei@de.ibm.com> wrote:
>
>> Indicate that HEA calculates IPv4 checksums only
>>
>> Signed-off-by: Thomas Klein <tklein@de.ibm.com>
>>
>> ---
>> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
>> --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h 2008-03-17 00:32:14.000000000 +0100
>> +++ patched_kernel/drivers/net/ehea/ehea.h 2008-03-19 08:58:07.000000000 +0100
>> @@ -40,7 +40,7 @@
>> #include <asm/io.h>
>>
>> #define DRV_NAME "ehea"
>> -#define DRV_VERSION "EHEA_0087"
>> +#define DRV_VERSION "EHEA_0089"
>>
>> /* eHEA capability flags */
>> #define DLPAR_PORT_ADD_REM 1
>> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
>> --- linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c 2008-03-17 00:32:14.000000000 +0100
>> +++ patched_kernel/drivers/net/ehea/ehea_main.c 2008-03-19 08:58:07.000000000 +0100
>> @@ -3108,7 +3108,7 @@ struct ehea_port *ehea_setup_single_port
>> dev->vlan_rx_add_vid = ehea_vlan_rx_add_vid;
>> dev->vlan_rx_kill_vid = ehea_vlan_rx_kill_vid;
>> dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
>> - | NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX
>> + | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
>> | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER
>> | NETIF_F_LLTX;
>> dev->tx_timeout = &ehea_tx_watchdog;
>
> That looks like a pretty significant fix to me? Should it be backported to
> 2.6.24.x?
Agreed. I'll send a patch.
Thomas
next prev parent reply other threads:[~2008-03-25 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 12:55 [PATCH] ehea: Fix IPv6 support Thomas Klein
2008-03-20 21:54 ` Andrew Morton
2008-03-25 15:41 ` Thomas Klein [this message]
2008-03-26 3:20 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E91D10.5060607@de.ibm.com \
--to=osstklei@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hering2@de.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=raisch@de.ibm.com \
--cc=stable@kernel.org \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).