From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <osstklei@de.ibm.com>
Received: from mtagate5.uk.ibm.com (mtagate5.uk.ibm.com [195.212.29.138])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mtagate5.uk.ibm.com", Issuer "Equifax" (verified OK))
	by ozlabs.org (Postfix) with ESMTPS id 203AFDE14B
	for <linuxppc-dev@ozlabs.org>; Wed, 26 Mar 2008 02:41:13 +1100 (EST)
Received: from d06nrmr1407.portsmouth.uk.ibm.com
	(d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185])
	by mtagate5.uk.ibm.com (8.13.8/8.13.8) with ESMTP id m2PFf7Nu226362
	for <linuxppc-dev@ozlabs.org>; Tue, 25 Mar 2008 15:41:07 GMT
Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com
	[9.149.37.213])
	by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v8.7) with
	ESMTP id m2PFf7mg2081012
	for <linuxppc-dev@ozlabs.org>; Tue, 25 Mar 2008 15:41:07 GMT
Received: from d06av03.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av03.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id m2PFf6p3014065
	for <linuxppc-dev@ozlabs.org>; Tue, 25 Mar 2008 15:41:06 GMT
Message-ID: <47E91D10.5060607@de.ibm.com>
Date: Tue, 25 Mar 2008 16:41:04 +0100
From: Thomas Klein <osstklei@de.ibm.com>
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ehea: Fix IPv6 support
References: <200803191355.44266.osstklei@de.ibm.com>
	<20080320145456.f0b6d101.akpm@linux-foundation.org>
In-Reply-To: <20080320145456.f0b6d101.akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: jeff@garzik.org, themann@de.ibm.com, netdev@vger.kernel.org,
	hering2@de.ibm.com, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, raisch@de.ibm.com,
	stefan.roscher@de.ibm.com, stable@kernel.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

Andrew Morton wrote:
> On Wed, 19 Mar 2008 13:55:43 +0100
> Thomas Klein <osstklei@de.ibm.com> wrote:
> 
>> Indicate that HEA calculates IPv4 checksums only
>>
>> Signed-off-by: Thomas Klein <tklein@de.ibm.com>
>>
>> ---
>> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
>> --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h	2008-03-17 00:32:14.000000000 +0100
>> +++ patched_kernel/drivers/net/ehea/ehea.h	2008-03-19 08:58:07.000000000 +0100
>> @@ -40,7 +40,7 @@
>>  #include <asm/io.h>
>>  
>>  #define DRV_NAME	"ehea"
>> -#define DRV_VERSION	"EHEA_0087"
>> +#define DRV_VERSION	"EHEA_0089"
>>  
>>  /* eHEA capability flags */
>>  #define DLPAR_PORT_ADD_REM 1
>> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
>> --- linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c	2008-03-17 00:32:14.000000000 +0100
>> +++ patched_kernel/drivers/net/ehea/ehea_main.c	2008-03-19 08:58:07.000000000 +0100
>> @@ -3108,7 +3108,7 @@ struct ehea_port *ehea_setup_single_port
>>  	dev->vlan_rx_add_vid = ehea_vlan_rx_add_vid;
>>  	dev->vlan_rx_kill_vid = ehea_vlan_rx_kill_vid;
>>  	dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
>> -		      | NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX
>> +		      | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
>>  		      | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER
>>  		      | NETIF_F_LLTX;
>>  	dev->tx_timeout = &ehea_tx_watchdog;
> 
> That looks like a pretty significant fix to me?  Should it be backported to
> 2.6.24.x?

Agreed. I'll send a patch.

Thomas