From: Scott Wood <scottwood@freescale.com>
To: Jochen Friedrich <jochen@scram.de>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [POWERPC] CPM1: implement GPIO LIB API
Date: Tue, 25 Mar 2008 12:16:00 -0500 [thread overview]
Message-ID: <47E93350.6090806@freescale.com> (raw)
In-Reply-To: <47E92EC8.7010700@scram.de>
Jochen Friedrich wrote:
> diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig
> index 7fd224c..e12cbf0 100644
> --- a/arch/powerpc/platforms/8xx/Kconfig
> +++ b/arch/powerpc/platforms/8xx/Kconfig
> @@ -4,6 +4,8 @@ config FADS
> config CPM1
> bool
> select CPM
> + select GENERIC_GPIO
> + select GPIO_LIB
Shouldn't this depend on the user enabling GPIO support? Some 8xx
boards are very memory-constrained, so we don't want to be making the
kernel even bigger than it already is unless it's actually needed.
-Scott
next prev parent reply other threads:[~2008-03-25 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 16:56 [PATCH] [POWERPC] CPM1: implement GPIO LIB API Jochen Friedrich
2008-03-25 17:16 ` Scott Wood [this message]
2008-03-26 17:47 ` Jochen Friedrich
2008-03-26 18:04 ` Scott Wood
2008-04-03 11:19 ` Laurent Pinchart
2008-04-03 12:31 ` Jochen Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E93350.6090806@freescale.com \
--to=scottwood@freescale.com \
--cc=jochen@scram.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).