From: Scott Wood <scottwood@freescale.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd/nand/fsl_elbc_nand: workaround for hangs on MPC837X
Date: Fri, 28 Mar 2008 13:53:57 -0500 [thread overview]
Message-ID: <47ED3EC5.8030508@freescale.com> (raw)
In-Reply-To: <20080328184303.GA25882@localhost.localdomain>
Anton Vorontsov wrote:
> @@ -495,6 +495,16 @@ static void fsl_elbc_write_buf(struct mtd_info *mtd, const u8 *buf, int len)
> }
>
> memcpy_toio(&ctrl->addr[ctrl->index], buf, len);
> +#ifdef CONFIG_PPC_MPC837x
> + /*
> + * This is workaround for the weird elbc hangs on the MPC837X CPUs,
> + * Scott Wood says: "...perhaps difference in how long it takes a
> + * write to make it through the localbus compared to a write to IMMR
> + * is causing problems, and sync isn't helping for some reason."
> + * Reading back the last byte helps though.
> + */
> + in_8(&ctrl->addr[ctrl->index] + len - 1);
> +#endif
Let's do it regardless of chip -- odds are the issue exists on all
implementations, and it's just a function of what frequencies things are
running at.
-Scott
next prev parent reply other threads:[~2008-03-28 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 18:43 [PATCH] mtd/nand/fsl_elbc_nand: workaround for hangs on MPC837X Anton Vorontsov
2008-03-28 18:53 ` Scott Wood [this message]
2008-03-28 19:10 ` [PATCH] mtd/nand/fsl_elbc_nand: workaround for hangs during nand write [was: Re: [PATCH] mtd/nand/fsl_elbc_nand: workaround for hangs on MPC837X] Anton Vorontsov
2008-03-28 19:15 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED3EC5.8030508@freescale.com \
--to=scottwood@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).