* [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__' [not found] <47F26FF6.8070300@tiscali.nl> @ 2008-04-01 17:31 ` Roel Kluin 2008-04-01 18:01 ` Sam Ravnborg 2008-04-01 21:36 ` Paul Mackerras 0 siblings, 2 replies; 3+ messages in thread From: Roel Kluin @ 2008-04-01 17:31 UTC (permalink / raw) To: paulus; +Cc: linuxppc-dev, trivial, lkml replace `__attribute' by `__attribute__' Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/arch/powerpc/platforms/iseries/main_store.h b/arch/powerpc/platforms/iseries/main_store.h index 1a7a3f5..976b23e 100644 --- a/arch/powerpc/platforms/iseries/main_store.h +++ b/arch/powerpc/platforms/iseries/main_store.h @@ -61,7 +61,7 @@ struct IoHriMainStoreSegment4 { }; /* Main Store VPD for Power4 */ -struct __attribute((packed)) IoHriMainStoreChipInfo1 { +struct __attribute__((packed)) IoHriMainStoreChipInfo1 { u32 chipMfgID; char chipECLevel[4]; }; @@ -73,14 +73,14 @@ struct IoHriMainStoreVpdIdData { char serialNumber[12]; }; -struct __attribute((packed)) IoHriMainStoreVpdFruData { +struct __attribute__((packed)) IoHriMainStoreVpdFruData { char fruLabel[8]; u8 numberOfSlots; u8 pluggingType; u16 slotMapIndex; }; -struct __attribute((packed)) IoHriMainStoreAdrRangeBlock { +struct __attribute__((packed)) IoHriMainStoreAdrRangeBlock { void *blockStart; void *blockEnd; u32 blockProcChipId; @@ -88,7 +88,7 @@ struct __attribute((packed)) IoHriMainStoreAdrRangeBlock { #define MaxAreaAdrRangeBlocks 4 -struct __attribute((packed)) IoHriMainStoreArea4 { +struct __attribute__((packed)) IoHriMainStoreArea4 { u32 msVpdFormat; u8 containedVpdType; u8 reserved1; ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__' 2008-04-01 17:31 ` [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__' Roel Kluin @ 2008-04-01 18:01 ` Sam Ravnborg 2008-04-01 21:36 ` Paul Mackerras 1 sibling, 0 replies; 3+ messages in thread From: Sam Ravnborg @ 2008-04-01 18:01 UTC (permalink / raw) To: Roel Kluin; +Cc: trivial, linuxppc-dev, paulus, lkml On Tue, Apr 01, 2008 at 07:31:01PM +0200, Roel Kluin wrote: > replace `__attribute' by `__attribute__' > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> > --- > diff --git a/arch/powerpc/platforms/iseries/main_store.h b/arch/powerpc/platforms/iseries/main_store.h > index 1a7a3f5..976b23e 100644 > --- a/arch/powerpc/platforms/iseries/main_store.h > +++ b/arch/powerpc/platforms/iseries/main_store.h > @@ -61,7 +61,7 @@ struct IoHriMainStoreSegment4 { > }; > > /* Main Store VPD for Power4 */ > -struct __attribute((packed)) IoHriMainStoreChipInfo1 { > +struct __attribute__((packed)) IoHriMainStoreChipInfo1 { > u32 chipMfgID; > char chipECLevel[4]; > }; Please introduce __packed if you touch this. See include/linux/compiler-gcc.h This comment is relevant for all your patches. We have __used and other similar variants. So take a good look at include/linux/compiler* and use the proper shortcuts where available. Sam ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__' 2008-04-01 17:31 ` [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__' Roel Kluin 2008-04-01 18:01 ` Sam Ravnborg @ 2008-04-01 21:36 ` Paul Mackerras 1 sibling, 0 replies; 3+ messages in thread From: Paul Mackerras @ 2008-04-01 21:36 UTC (permalink / raw) To: Roel Kluin; +Cc: linuxppc-dev, trivial, lkml Roel Kluin writes: > replace `__attribute' by `__attribute__' Why? Your commit message doesn't give any motivation. Paul. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-01 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <47F26FF6.8070300@tiscali.nl>
2008-04-01 17:31 ` [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__' Roel Kluin
2008-04-01 18:01 ` Sam Ravnborg
2008-04-01 21:36 ` Paul Mackerras
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).