linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: avorontsov@ru.mvista.com
Cc: Scott Wood <scottwood@freescale.com>,
	linux-usb@vger.kernel.org, David Brownell <david-b@pacbell.net>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Freescale QUICC Engine USB Host Controller
Date: Thu, 03 Apr 2008 10:33:04 -0500	[thread overview]
Message-ID: <47F4F8B0.4090708@freescale.com> (raw)
In-Reply-To: <20080403143052.GA5955@polina.dev.rtsoft.ru>

Anton Vorontsov wrote:

> Yeah, I already posted a patch to deal with it, see
> http://ozlabs.org/pipermail/linuxppc-dev/2008-March/053249.html
> (btw... Scott, Timur did you have a chance to look into this?)

Seems to be okay.  I presume the code actually works with these changes. :-)

My only concern is that the functions are still called cpm_xxxx even though they
apply to the CPM and the QE.  Sure, the QE is really just CPM3, but I'd like to
see a nomenclature that's more inclusive.

We should also be able to get rid of cpm_alloc/free functions anyway, since
they're just front-ends to the rheap code.  But that's a problem for another time.

> Well, there is Linux CLK API (somewhat similar to GPIO API), but PowerPC
> doesn't use it yet.

Yeah, I noticed that too.  I'll add it to my to-do list, but I suspect that
someone else will get around to it before I do.

-- 
Timur Tabi
Linux kernel developer at Freescale

  parent reply	other threads:[~2008-04-03 15:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 19:17 [PATCH] Freescale QUICC Engine USB Host Controller Anton Vorontsov
2008-03-11 21:32 ` Joakim Tjernlund
2008-04-03 13:45 ` Laurent Pinchart
2008-04-03 14:30   ` Anton Vorontsov
2008-04-03 15:27     ` Scott Wood
2008-04-03 15:33     ` Timur Tabi [this message]
2008-04-03 15:36       ` Scott Wood
2008-04-03 18:22       ` David Brownell
2008-04-07 16:11     ` Laurent Pinchart
2008-04-08 12:16       ` Anton Vorontsov
2008-04-09 12:13         ` Laurent Pinchart
2008-04-09 12:16           ` Pandita, Vikram
2008-04-09 12:20             ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F4F8B0.4090708@freescale.com \
    --to=timur@freescale.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=david-b@pacbell.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).