LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH RFC] tqm8560.dts: add local bus devices
Date: Sun, 06 Apr 2008 20:45:32 +0200	[thread overview]
Message-ID: <47F91A4C.6030109@grandegger.com> (raw)
In-Reply-To: <47F90B97.4080904@grandegger.com>

Wolfgang Grandegger wrote:
> Segher Boessenkool wrote:
>>> +                        partition@300000 {
>>> +                                label = "fs";
>>> +                                reg = <0x00300000 0x07c00000>;
>>> +                        };
>>> +                        partition@7700000 {
>>> +                                label = "firmware";
>>> +                                reg = <0x07700000 0x00100000>;
>> These two overlap; should the latter be @7f00000?
> 
> Yes, of course.
> 
>>> +        can@2,0 {
>>> +            device_type = "can";
>> No device_type please.
> 
> OK, but then I better use a more descriptive name for the compatible
> property, e.g.:
> 
> 	compatible = "can-i82527";	// Intel 82527 or Bosch CC770
> 
>>> +        nand@3,0 {
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            compatible = "fsl,mpc8560-fcm-nand",
>>> +                         "fsl,elbc-fcm-nand";
>>> +            reg = <0x3 0x0 0x8000>;
>>> +
>>> +            kernel@0 {
>>> +                                label = "kernel";
>>> +                reg = <0x000000 0x0300000>;
>>> +            };
>>> +            fs@300000 {
>>> +                                label = "fs";
>>> +                reg = <0x300000 0x7d00000>;
>>> +            };
>>> +        };
>>> +    };
>> There should be a node that describes the nand chip between the nand
>> controller node and the partition nodes.
> 
> I took the mpc8378_*.dts files of 2.6.25-rc8 as example and there is no
> such node. Could you point me please to a more appropriate example.

In the meantime I realized, that the upcoming FSL UPM driver seems to be
appropriate for that board:

  http://ozlabs.org/pipermail/linuxppc-dev/2008-March/052890.html

What is the status of this driver? Are there already some boards using
it (including DTS file)?

Wolfgang.

      reply	other threads:[~2008-04-06 18:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-06 12:29 [PATCH RFC] tqm8560.dts: add local bus devices Wolfgang Grandegger
     [not found] ` <0d57d42da9d29cc240be9d38de29ed96@kernel.crashing.org>
2008-04-06 17:42   ` Wolfgang Grandegger
2008-04-06 18:45     ` Wolfgang Grandegger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F91A4C.6030109@grandegger.com \
    --to=wg@grandegger.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox