From: Tejun Heo <htejun@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, gregkh@suse.de,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 6/13] devres: implement managed iomap interface
Date: Tue, 08 Apr 2008 23:48:43 +0900 [thread overview]
Message-ID: <47FB85CB.2070506@gmail.com> (raw)
In-Reply-To: <47FA4FD2.8060808@ru.mvista.com>
Sergei Shtylyov wrote:
> A very late comment but nevertheless... :-)
Better late than never.
> Those functions are going to break on 32-bit platforms with extended
> physical address (well, that's starting with Pentiums which had 36-bit
> PAE :-) AND devices mapped beyond 4 GB (e.g. PowerPC 44x). You should
> have used resource_size_t for the 'offset' parameter. As this most
> probably means that libata is broken on such platforms, I'm going to
> submit a patch...
Yeah, right please go ahead. But I wonder whether any BIOS was actually
crazy enough to map mmio region above 4G on 32bit machine.
--
tejun
next prev parent reply other threads:[~2008-04-08 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11684073371547-git-send-email-htejun@gmail.com>
2008-04-07 16:46 ` [PATCH 6/13] devres: implement managed iomap interface Sergei Shtylyov
2008-04-08 14:48 ` Tejun Heo [this message]
2008-04-08 14:55 ` Sergei Shtylyov
2008-04-08 15:03 ` Tejun Heo
2008-04-10 16:56 ` Sergei Shtylyov
2008-04-10 17:44 ` Kumar Gala
2008-04-10 18:24 ` Sergei Shtylyov
2008-04-10 19:40 ` Kumar Gala
2008-04-11 2:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FB85CB.2070506@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).